Differential D25196

Perform KNS searches from the Featured page again
ClosedPublic
Actions

Authored by ngraham on Nov 7 2019, 3:03 PM.

Details

Reviewers
apol
Group Reviewers
Discover Software Store
Commits
R134:11d79794b58e: Perform KNS searches from the Featured page again
Summary

We previously disabled this in https://bugs.kde.org/show_bug.cgi?id=399503 to improve
the relevancy of the search results. However since then, searching has been improved in
various other ways. For example, exact title matches are now shown first, and apps are
shown before KNS entries. Therefore, it seems reasonable to re-enable KNS searches from
the Featured page.

BUG: 413880
FIXED-IN: 5.18.0

Test Plan

Can now find "Fokus" from a search inittated while viewing the Featured page.

Diff Detail

Repository
R134 Discover Software Store
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ngraham created this revision.Nov 7 2019, 3:03 PM
Restricted Application added a project: Plasma. · View Herald TranscriptNov 7 2019, 3:03 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.Nov 7 2019, 3:03 PM
apol added a comment.Nov 7 2019, 7:00 PM

How about we target master for this?

libdiscover/backends/KNSBackend/KNSBackend.cpp
507

The comment should be //Accept global searches, the featured page queries by URL.

ngraham marked an inline comment as done.Nov 7 2019, 7:06 PM

Sure, master only is fine.

ngraham edited the summary of this revision. (Show Details)Nov 7 2019, 7:06 PM
ngraham updated this revision to Diff 69407.Nov 7 2019, 7:06 PM
ngraham edited the summary of this revision. (Show Details)

Update comment

ngraham edited the summary of this revision. (Show Details)Nov 7 2019, 7:07 PM
apol accepted this revision.Nov 8 2019, 5:49 PM
This revision is now accepted and ready to land.Nov 8 2019, 5:49 PM
Closed by commit R134:11d79794b58e: Perform KNS searches from the Featured page again (authored by ngraham). · Explain WhyNov 8 2019, 5:50 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 69479

View Options

libdiscover/backends/KNSBackend/KNSBackend.cpp

Loading...