Differential D25190

Translates the Search placeholder in kcm_kwin_effects
AbandonedPublic
Actions

Authored by meven on Nov 7 2019, 12:54 PM.

Details

Reviewers
davidedmundson
Group Reviewers
KWin
Summary

BUG:413900

Diff Detail

Repository
R108 KWin
Branch
master
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 18561
Build 18579: arc lint + arc unit
meven created this revision.Nov 7 2019, 12:54 PM
Restricted Application added a project: KWin. · View Herald TranscriptNov 7 2019, 12:54 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
meven requested review of this revision.Nov 7 2019, 12:54 PM
davidedmundson requested changes to this revision.Nov 7 2019, 1:00 PM
davidedmundson added a subscriber: davidedmundson.

Kirigami has:
SearchField.qml

placeholderText: qsTr("Search...")

If there is a bug (lack of domain set / loaded) we need to fix that at the root.

This revision now requires changes to proceed.Nov 7 2019, 1:00 PM
meven added a comment.Nov 7 2019, 1:33 PM
In D25190#559568, @davidedmundson wrote:

Kirigami has:
SearchField.qml

placeholderText: qsTr("Search...")

If there is a bug (lack of domain set / loaded) we need to fix that at the root.

It seems kirigami does not depend on KF5I18n at the moment, I saw from other code in plasma this was common to do this replacement.

davidedmundson added a comment.Nov 7 2019, 1:53 PM

I saw from other code in plasma this was common to do this replacement.

Where? There are lots of TextFields with the placeholder set.

The SearchFields I found (notifications KCM, systemsettings, discover) didn't.
Which either means they exhibit the same bug, or they do something we're not doing.

meven abandoned this revision.Nov 7 2019, 2:03 PM
In D25190#559587, @davidedmundson wrote:

I saw from other code in plasma this was common to do this replacement.

Where? There are lots of TextFields with the placeholder set.

The SearchFields I found (notifications KCM, systemsettings, discover) didn't.

You are right I naively assumed some of the grep'ed instance of placeholderText concerned SeachField but it didn't.

Which either means they exhibit the same bug, or they do something we're not doing.

They don't exhibit the bug, so the bug is most likely in kwineffects kcm.
Will look into it.

Revision Contents
Changeset List

Diff 69387

View Options

kcmkwin/kwineffects/package/contents/ui/main.qml

Loading...