Use the aether theme and clean the html/js code
AcceptedPublic

Authored by ognarb on Wed, Nov 6, 11:37 PM.

Details

Reviewers
jriddell
Group Reviewers
Websites
Test Plan

Only the template was tested in Firefox

Diff Detail

Repository
R954 Planet (Blogosphere) for KDE (customised Rawdog)
Branch
use-aether (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 18607
Build 18625: arc lint + arc unit
ognarb requested review of this revision.Wed, Nov 6, 11:37 PM
ognarb created this revision.
ognarb edited the summary of this revision. (Show Details)Wed, Nov 6, 11:38 PM
ognarb added reviewers: Websites, jriddell.
bcooksley added inline comments.
planetkde/planet_template
19

Typos?

fron -> from
bootrap.js -> bootstrap.js

ognarb updated this revision to Diff 69381.Thu, Nov 7, 10:39 AM
  • Fix types
  • Fix layout for mobile
  • http -> https
  • Fix modal
  • Fix error in js code
  • Fix french -> French
ognarb marked an inline comment as done.Thu, Nov 7, 10:39 AM
ognarb edited the summary of this revision. (Show Details)Thu, Nov 7, 10:42 AM
ognarb edited the test plan for this revision. (Show Details)

This change looks fine to me, i'll leave it to Jonathan to give final approval on though.

planetkde/planet_template
29–30

Unrelated to this, but I wonder if we should move the favicon's to the CDN as well?

jriddell accepted this revision.Fri, Nov 8, 2:30 PM

Looking good

There's no maximum width on the main text that I can see, I wonder if it'll become uncomfortably wide to read on large monitors

I'd like to get rid of the Twitter feed, it doesn't seem to be useful and it's never updated.

This revision is now accepted and ready to land.Fri, Nov 8, 2:30 PM
ognarb updated this revision to Diff 69448.Fri, Nov 8, 2:49 PM

Remove twitter feed

ognarb updated this revision to Diff 69449.Fri, Nov 8, 2:54 PM

Use implicitly max-width with a bootstrap container