Differential D25180

[GTK3/Firefox] Fix scrollbar click region
ClosedPublic
Actions

Authored by cblack on Nov 6 2019, 9:19 PM.

Details

Reviewers
ngraham
Group Reviewers
VDG
Breeze
Commits
R98:be9775281fa9: [GTK3/Firefox] Fix scrollbar click region
R98:37058bade9e3: Merge branch 'Plasma/5.17' - Firefox scrollbar fix
Summary

Scrollbars now have a click region equivalent to their visual space in Firefox.

FIXED-IN: 5.17.3
BUG: 413118

Test Plan

Before: 5px edge on scrollbars doesn't respond to clicks.

After: 5px edge on scrollbars responds to clicks.

Diff Detail

Repository
R98 Breeze for Gtk
Branch
scrollbar-click-region (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 18546
Build 18564: arc lint + arc unit
cblack created this revision.Nov 6 2019, 9:19 PM
Restricted Application added a project: Plasma. · View Herald TranscriptNov 6 2019, 9:19 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
cblack requested review of this revision.Nov 6 2019, 9:19 PM
cblack edited the summary of this revision. (Show Details)Nov 6 2019, 9:20 PM
cblack edited the test plan for this revision. (Show Details)
ngraham accepted this revision.Nov 6 2019, 9:22 PM
ngraham added a subscriber: ngraham.

Works perfectly.

Definitely 5.17.x material, especially since the bug we're fixing was a regression in 5.17.

This revision is now accepted and ready to land.Nov 6 2019, 9:22 PM
cblack edited the summary of this revision. (Show Details)Nov 8 2019, 9:13 PM
Closed by commit R98:be9775281fa9: [GTK3/Firefox] Fix scrollbar click region (authored by cblack). · Explain WhyNov 8 2019, 9:17 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
AMsrc/gtk3/applications/_firefox.scss (8 lines)
Msrc/gtk3/gtk.scss (3 lines)

Diff 69364

View Options

src/gtk3/applications/_firefox.scss

Loading...
View Options

src/gtk3/gtk.scss

Loading...