Differential D25165

Only show DownloadItemsSheet if there's more than one download item
ClosedPublic
Actions

Authored by leinir on Nov 6 2019, 10:25 AM.

Details

Reviewers
ngraham
Group Reviewers
KNewStuff
Frameworks
Commits
R304:7de5ad66fd89: Only show DownloadItemsSheet if there's more than one download item
Summary

This was caused by using the downloadCount (which is the total number of times the item has been downloaded), rather than the length of the list of download items.

BUG:413437

Test Plan

With patch: Shows "Install..." for all items (with other than one user download)
Without patch: Shows "Install..." only for items with more than one download item

Diff Detail

Repository
R304 KNewStuff
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
leinir created this revision.Nov 6 2019, 10:25 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptNov 6 2019, 10:25 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
leinir requested review of this revision.Nov 6 2019, 10:25 AM
leinir edited the summary of this revision. (Show Details)Nov 6 2019, 11:12 AM
leinir added reviewers: KNewStuff, Frameworks, ngraham.
ngraham accepted this revision.Nov 7 2019, 1:01 AM
This revision is now accepted and ready to land.Nov 7 2019, 1:01 AM
Closed by commit R304:7de5ad66fd89: Only show DownloadItemsSheet if there's more than one download item (authored by leinir). · Explain WhyNov 7 2019, 9:24 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 69377

View Options

src/qtquick/qml/private/entrygriddelegates/BigPreviewDelegate.qml

Loading...
View Options

src/qtquick/qml/private/entrygriddelegates/ThumbDelegate.qml

Loading...
View Options

src/qtquick/qml/private/entrygriddelegates/TileDelegate.qml

Loading...