Differential D25160

[Folder View] Use an inactive highlight effect when something else has focus
ClosedPublic
Actions

Authored by ngraham on Nov 5 2019, 7:31 PM.

Details

Reviewers
davidedmundson
Group Reviewers
Plasma
VDG
Commits
R119:596f979d45c5: [Folder View] Use an inactive highlight effect when something else has focus
Summary

The theme SVG doesn't have a concept of "inactive selection highlight", so we need to
manufacture our own by reducing the opacity of the selection highlight.

Thanks to @broulik for suggesting the necessary code changes in the bug report.

FEATURE: 375501
FIXED-IN: 5.18.0

Test Plan

Diff Detail

Repository
R119 Plasma Desktop
Branch
folder-view-inactive-selection-highlight (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 18523
Build 18541: arc lint + arc unit
ngraham created this revision.Nov 5 2019, 7:31 PM
Restricted Application added a project: Plasma. · View Herald TranscriptNov 5 2019, 7:31 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.Nov 5 2019, 7:31 PM
davidedmundson accepted this revision.Nov 5 2019, 7:48 PM
This revision is now accepted and ready to land.Nov 5 2019, 7:48 PM
Closed by commit R119:596f979d45c5: [Folder View] Use an inactive highlight effect when something else has focus (authored by ngraham). · Explain WhyNov 5 2019, 8:14 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 69327

View Options

containments/desktop/package/contents/ui/FolderItemDelegate.qml

Loading...