Add option to enable or disable internal PDF viewer from Qt 5.13
ClosedPublic

Authored by stefanocrocco on Sun, Nov 3, 5:19 PM.

Details

Summary

Add an option to allow the user to choose whether or not to display
PDF files opened from web pages using WebEngine.

This doesn't affect PDF files not opened from web pages (for example, files
opened from Dolphin Part).

The default is NOT to use the internal viewer.

The option is at the bottom of the Miscellaneous section of the Web Behavior
page in the configuration dialog. Maybe it should be made more visible.

Test Plan

go to a web page with a link to a PDF file and click on the link:
with the option disabled Konqueror opens the PDF using a KPart; with the option
enabled, it opens it in the same WebEnginePart.

Diff Detail

Repository
R226 Konqueror
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
stefanocrocco requested review of this revision.Sun, Nov 3, 5:19 PM
stefanocrocco created this revision.
  • Fix compilation with Qt before 5.13
dfaure accepted this revision.Sun, Nov 3, 7:26 PM

You can push after making the change (I'll be away for 2 weeks)

CMakeLists.txt
32

VERSION_GREATER_EQUAL was added in CMake 3.7. To keep supporting older versions of cmake, use
NOT VERSION_LESS instead.

This revision is now accepted and ready to land.Sun, Nov 3, 7:26 PM

Keep compatibility with older versions of CMake

This revision was automatically updated to reflect the committed changes.