Adding tooltip to symbolsviewer plugin
ClosedPublic

Authored by ofelt on Aug 20 2016, 11:21 PM.

Details

Summary

Tooltip was not used previously.
This patch display function parameters in tooltip.

Test Plan

Expect same behavior as before and see correct tooltips.
Opened with 3 test files (php, cpp, rb) in kate.
Behavior same as before and tooltips are correct.

Diff Detail

Repository
R40 Kate
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ofelt updated this revision to Diff 6108.Aug 20 2016, 11:21 PM
ofelt retitled this revision from to Adding tooltip to symbolsviewer plugin.
ofelt updated this object.
ofelt edited the test plan for this revision. (Show Details)
ofelt added a reviewer: kwrite-devel.
ofelt set the repository for this revision to R40 Kate.
ofelt added a project: Kate.
ofelt added a subscriber: kwrite-devel.

Hi there, It's my first patch for KDE, it's a small thing but useful :) Any advice is welcome ^^ Thanks. Oli

ofelt added a reviewer: Kate.Aug 21 2016, 8:14 AM
ofelt added a subscriber: Kate.
cullmann accepted this revision.Sep 3 2016, 3:14 PM
cullmann added a reviewer: cullmann.
cullmann added a subscriber: cullmann.

I would accept that way, can you commit it yourself?

This revision is now accepted and ready to land.Sep 3 2016, 3:14 PM
ofelt added a comment.Sep 3 2016, 8:21 PM

I don't have commit access yet, if you can commit it for me (Olivier Felt, olivier.felt@kdemail.net) it would be great
Thanks for your time

This revision was automatically updated to reflect the committed changes.