update panel shadows when background hints are changed
ClosedPublic

Authored by mvourlakos on Nov 2 2019, 5:02 PM.

Details

Summary

--when the containment background hints are updated then the
panel shadows should be also. In case the background hints
point to NoBackground the panel shadows should be removed
and in case they point to DefaultBackground they should be
drawn again
--PanelShadows::removeWindow has no place in updateEnabledBorders
because the window still lives. When removeWindow was executed
before it was faulty unregistered from PanelShadows and in order for
setEnabledBorders to work again we should need
to execute from start the PanelShadows::addWindow function

Test Plan

--I have created an applet which a PlasmaComponents.Switch button
and toggles panel transparency on user demand easily

Diff Detail

Repository
R120 Plasma Workspace
Branch
updatePanelShadows
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 18448
Build 18466: arc lint + arc unit
mvourlakos created this revision.Nov 2 2019, 5:02 PM
Restricted Application added a project: Plasma. · View Herald TranscriptNov 2 2019, 5:02 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
mvourlakos requested review of this revision.Nov 2 2019, 5:02 PM
mvourlakos edited the summary of this revision. (Show Details)Nov 3 2019, 11:17 AM
mvourlakos added reviewers: davidedmundson, mart.
davidedmundson accepted this revision.Nov 6 2019, 3:52 PM
This revision is now accepted and ready to land.Nov 6 2019, 3:52 PM
This revision was automatically updated to reflect the committed changes.