Differential D25115

Add guard for missing kirigami
ClosedPublic
Actions

Authored by davidedmundson on Nov 2 2019, 8:31 AM.

Details

Reviewers
apol
Group Reviewers
Plasma
Commits
R295:6f8610a1431a: Add guard for missing kirigami
Summary

We rely on the component being created correctly later in the module,
better to fatal with a useful messgae than crash.

CCBUG: 405023

Test Plan

Regular KCM still loaded fine

Diff Detail

Repository
R295 KCMUtils
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidedmundson created this revision.Nov 2 2019, 8:31 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptNov 2 2019, 8:31 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
davidedmundson requested review of this revision.Nov 2 2019, 8:31 AM
apol accepted this revision.Nov 3 2019, 2:29 AM
This revision is now accepted and ready to land.Nov 3 2019, 2:29 AM
Closed by commit R295:6f8610a1431a: Add guard for missing kirigami (authored by davidedmundson). · Explain WhyNov 7 2019, 6:11 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/kcmoduleqml.cpp (4 lines)

Diff 69404

View Options

src/kcmoduleqml.cpp

Loading...