Differential D25109

Make it impossible to open the progress view sheet multiple times
ClosedPublic
Actions

Authored by jbbgameich on Nov 1 2019, 8:38 PM.

Details

Reviewers
apol
Group Reviewers
Discover Software Store
Commits
R134:762a36fcd96b: Make it impossible to open the progress view sheet multiple times
Summary

It used to be possible after resizing the window so narrowly that the drawer switched into modal mode and back to its original width.
There is still the question of why the sheet is sometimes left behind the drawer, but that's probably something for another patch.

Test Plan

Multiple ProgressView sheets can't be opened at the same time anymore

Diff Detail

Repository
R134 Discover Software Store
Branch
progress-view-open-only-once (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 18429
Build 18447: arc lint + arc unit
jbbgameich created this revision.Nov 1 2019, 8:38 PM
Restricted Application added a project: Plasma. · View Herald TranscriptNov 1 2019, 8:38 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
jbbgameich requested review of this revision.Nov 1 2019, 8:38 PM
apol accepted this revision.Nov 3 2019, 2:27 AM
This revision is now accepted and ready to land.Nov 3 2019, 2:27 AM
Closed by commit R134:762a36fcd96b: Make it impossible to open the progress view sheet multiple times (authored by jbbgameich). · Explain WhyNov 6 2019, 4:57 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mdiscover/qml/ProgressView.qml (9 lines)

Diff 69167

View Options

discover/qml/ProgressView.qml

Loading...