Differential D2509

Julia backed: other unit-tests
ClosedPublic
Actions

Authored by ivanlakhtanov on Aug 20 2016, 10:04 PM.

Details

Reviewers
filipesaraiva
Group Reviewers
Cantor
Maniphest Tasks
T1753: Add support for Julia (julialang-backend)
Commits
R55:66a2dc3499fd: Added unit-tests for several parts
Summary

Added unit-tests for several parts

* Variable management
* Inline plots
* Unit completion

Diff Detail

Repository
R55 Cantor
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ivanlakhtanov updated this revision to Diff 6105.Aug 20 2016, 10:04 PM
ivanlakhtanov retitled this revision from to Julia backed: other unit-tests.
ivanlakhtanov updated this object.
ivanlakhtanov edited the test plan for this revision. (Show Details)
ivanlakhtanov added reviewers: Cantor, filipesaraiva.
ivanlakhtanov set the repository for this revision to R55 Cantor.
ivanlakhtanov added a dependency: D2459: Julia backend: inline plots.
ivanlakhtanov added a task: T1753: Add support for Julia (julialang-backend).
ivanlakhtanov added subscribers: Cantor, filipesaraiva.
filipesaraiva edited edge metadata.Aug 22 2016, 12:24 AM

I am getting an error when I try to apply this patch. The error output is something like below (translated from Portuguese):

Verifying the patch src/backends/julia/tests/testjulia.h...
error: src/backends/julia/tests/testjulia.h: there is not in the index
Verifying the patch src/backends/julia/tests/testjulia.cpp...
error: src/backends/julia/tests/testjulia.cpp: there is not in the index

Try to reproduce the error applying the patch using arc patch D2509 or download the patch and use git apply D2509.

ivanlakhtanov added a comment.Aug 22 2016, 1:07 AM
In D2509#47157, @filipesaraiva wrote:

I am getting an error when I try to apply this patch. The error output is something like below (translated from Portuguese):

Verifying the patch src/backends/julia/tests/testjulia.h...
 error: src/backends/julia/tests/testjulia.h: there is not in the index
 Verifying the patch src/backends/julia/tests/testjulia.cpp...
 error: src/backends/julia/tests/testjulia.cpp: there is not in the index

Try to reproduce the error applying the patch using arc patch D2509 or download the patch and use git apply D2509.

Dependencies tree of patches were malformed. Now it looks fixed.

filipesaraiva requested changes to this revision.Aug 23 2016, 3:15 AM
filipesaraiva edited edge metadata.

The functions names are very informative but just add some comments before the functions explaining about the test performed.

This revision now requires changes to proceed.Aug 23 2016, 3:15 AM
ivanlakhtanov updated this revision to Diff 6168.Aug 23 2016, 4:32 AM
ivanlakhtanov edited edge metadata.

Added comments for tests

filipesaraiva accepted this revision.Aug 24 2016, 5:56 PM
filipesaraiva edited edge metadata.
This revision is now accepted and ready to land.Aug 24 2016, 5:56 PM
Closed by commit R55:66a2dc3499fd: Added unit-tests for several parts (authored by ivanlakhtanov). · Explain WhyAug 24 2016, 6:47 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 6234

View Options

src/backends/julia/tests/testjulia.h

Loading...
View Options

src/backends/julia/tests/testjulia.cpp

Loading...