Use X-KDE-NoGlobalShortcut instead of NoDisplay to store that a component is disabled
AbandonedPublic
Actions

Authored by meven on Oct 31 2019, 11:45 AM.

Details

Reviewers

broulik
apol

Group Reviewers

Plasma

Summary

Needed to allow apps to not be visible in menus but have shortcuts (i.e Krunner)
Using NoDisplay to store that a component is disabled conflics with the meaning of NoDisplay.
This is problem in Wayland as this platforms induces more desktop files to allow usage of KDE Wayland protocols and settings app icons for instance.

Relates to D24857

Diff Detail

Repository

R268 KGlobalAccel

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 18386
Build 18404: arc lint + arc unit

meven created this revision.Oct 31 2019, 11:45 AM

Restricted Application added a project: Frameworks. · View Herald TranscriptOct 31 2019, 11:45 AM

Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript

meven requested review of this revision.Oct 31 2019, 11:45 AM

Harbormaster completed remote builds in B18386: Diff 69097.Oct 31 2019, 11:45 AM

meven mentioned this in D25089: Use X-KDE-NoGlobalShortcut to read that an app has shorcuts disable.Oct 31 2019, 11:51 AM

davidedmundson added a subscriber: davidedmundson.Oct 31 2019, 12:58 PM

davidedmundson added inline comments.

src/runtime/kserviceactioncomponent.cpp
36	I don't think I follow. We're editing the .desktop file inside {XDG_DATA_DIRS}/kglobalaccel/someName.desktop The menu only reads from XDG_DATA_DIRS/applications/someName.desktop where's the conflict?

meven added inline comments.Oct 31 2019, 2:01 PM

src/runtime/kserviceactioncomponent.cpp
36	Because usually the desktop files are copies of the same as applications : install( DIRECTORY DESTINATION "${KDE_INSTALL_FULL_DATAROOTDIR}/kglobalaccel" ) So if you need to "NoDisplay" an app for krunner for instance, you also disable its shortcuts because the desktop files are copies of each other at installation. FYI XDG_DATA_DIRS is deprecated

davidre added a subscriber: davidre.Oct 31 2019, 2:32 PM

davidre added inline comments.

src/runtime/kserviceactioncomponent.cpp
36	Related to this discussion the KCM copies the desktop file to `.local/share/kglobalaccel` if you add one with the plus button. (As does D25086)

meven mentioned this in D24947: Install krunner desktop file to ${KDE_INSTALL_APPDIR}.Dec 8 2019, 7:10 PM

fvogt mentioned this in D24956: Consider desktop files with NoDisplay attribute.Apr 15 2020, 12:48 PM

davidre mentioned this in T12984: Disabling/Deleting desktop file components in KGlobalAccel.Apr 16 2020, 8:25 AM

D28856 should be preferred

Revision Contents
Changeset List

			Path	Packages
M			src/runtime/globalshortcutsregistry.cpp (2 lines)
M			src/runtime/kserviceactioncomponent.cpp (2 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	69097	3b3402d		Oct 31 2019, 11:45 AM	★	★

Use X-KDE-NoGlobalShortcut instead of NoDisplay to store that a component is disabledAbandonedPublicActions

Details

Diff Detail

Revision ContentsChangeset List

Diff 69097

src/runtime/globalshortcutsregistry.cpp

src/runtime/kserviceactioncomponent.cpp

Use X-KDE-NoGlobalShortcut instead of NoDisplay to store that a component is disabled
AbandonedPublic
Actions

Revision Contents
Changeset List