improve Reconciliation doc
ClosedPublic
Actions

Authored by skierpage on Oct 31 2019, 7:26 AM.

Details

Reviewers

yurchor
smankowski

Group Reviewers

Skrooge

Summary

These are pointed operations, not checked; give an example of Delta 0; explain the fake operation to complete validation (and avoid active voice); etc.

Also be consistent referring to "application's settings."

Test Plan

build the doc, look at Reconciliation section.

Diff Detail

Repository

R469 Skrooge

Lint

Lint Skipped

Unit

Unit Tests Skipped

skierpage created this revision.Oct 31 2019, 7:26 AM

Restricted Application added a project: Documentation. · View Herald TranscriptOct 31 2019, 7:26 AM

Restricted Application added a subscriber: kde-doc-english. · View Herald Transcript

skierpage requested review of this revision.Oct 31 2019, 7:26 AM

Thanks in advance for fixing these issues.

doc/index.docbook
1523	Missing comma: First -> First,
1541	Typo: forgot -> forgotten

In D25085#557022, @yurchor wrote:

Thanks in advance for fixing these issues.

Sure, happy to help. Alas, I can't get Arcanist setup, arc install-certificate fails with

Usage Exception: Failed to connect to server (https://phabricator.kde.org/api/): [cURL/77] (https://phabricator.kde.org/api/conduit.ping) <CURLE_SSL_CACERT_BADFILE> The SSL CA Bundles that we tried to use could not be read or are not formatted correctly.

from ArcanistInstallCertificateWorkflow::run(), and for which nobody on IRC has working suggestions. I don't think I can amend a patch in Differential using just git and Phabricator. I'll try to debug the PHP cli program and libcurl...

skierpage mentioned this in D25352: Improve Reconciliation doc.Nov 17 2019, 4:47 AM

yurchor accepted this revision.Nov 17 2019, 6:55 AM

This revision is now accepted and ready to land.Nov 17 2019, 6:55 AM