improve Reconciliation doc
ClosedPublic

Authored by spage on Thu, Oct 31, 7:26 AM.

Details

Reviewers
yurchor
smankowski
Group Reviewers
Skrooge
Summary

These are pointed operations, not checked; give an example of Delta 0; explain the fake operation to complete validation (and avoid active voice); etc.

Also be consistent referring to "application's settings."

Test Plan

build the doc, look at Reconciliation section.

Diff Detail

Repository
R469 Skrooge
Branch
arcpatch-D25085
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 18871
Build 18889: arc lint + arc unit
spage created this revision.Thu, Oct 31, 7:26 AM
Restricted Application added a project: Documentation. · View Herald TranscriptThu, Oct 31, 7:26 AM
Restricted Application added a subscriber: kde-doc-english. · View Herald Transcript
spage requested review of this revision.Thu, Oct 31, 7:26 AM

Thanks in advance for fixing these issues.

doc/index.docbook
1523

Missing comma: First -> First,

1541

Typo: forgot -> forgotten

spage marked 2 inline comments as done.Thu, Oct 31, 10:04 AM

Thanks in advance for fixing these issues.

Sure, happy to help. Alas, I can't get Arcanist setup, arc install-certificate fails with

Usage Exception: Failed to connect to server (https://phabricator.kde.org/api/): [cURL/77] (https://phabricator.kde.org/api/conduit.ping) <CURLE_SSL_CACERT_BADFILE> The SSL CA Bundles that we tried to use could not be read or are not formatted correctly.

from ArcanistInstallCertificateWorkflow::run(), and for which nobody on IRC has working suggestions. I don't think I can amend a patch in Differential using just git and Phabricator. I'll try to debug the PHP cli program and libcurl...

yurchor accepted this revision.Sun, Nov 17, 6:55 AM
This revision is now accepted and ready to land.Sun, Nov 17, 6:55 AM
spage updated this revision to Diff 69870.Sun, Nov 17, 8:34 AM
  • address yurchor's doc comments in Differential
yurchor accepted this revision.Sun, Nov 17, 8:52 AM
smankowski accepted this revision.Sun, Nov 17, 5:57 PM
smankowski added a subscriber: smankowski.

I did the commit. Thank you for your contribution.

smankowski closed this revision.Sun, Nov 17, 5:57 PM