Replace deprecated KConfigDialogManager::changedMap with property in the class definition
Needs ReviewPublic

Authored by yurchor on Wed, Oct 30, 3:34 PM.

Details

Reviewers
None
Group Reviewers
KDE Edu
Summary

KConfigDialogManager::changedMap is deprecated since KF 5.32. This commit mimics the replacement commit from Okteta:

https://cgit.kde.org/okteta.git/commit/?id=1ed966965b656bac22e1fe99e1b7ede00da68263

Test Plan

Compiles. It seems that Equation editor behavior does not change.

Diff Detail

Repository
R334 KmPlot
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 18382
Build 18400: arc lint + arc unit
yurchor created this revision.Wed, Oct 30, 3:34 PM
Restricted Application added a project: KDE Edu. · View Herald TranscriptWed, Oct 30, 3:34 PM
Restricted Application added a subscriber: kde-edu. · View Herald Transcript
yurchor requested review of this revision.Wed, Oct 30, 3:34 PM
aacid added a subscriber: aacid.Wed, Oct 30, 8:43 PM

Given that almost everything ships KF5 > 5.32
https://repology.org/project/kconfig/badges

Maybe we can just require
KF 5.32 in CMakeLists.txt and remove the ifdef?

yurchor updated this revision to Diff 69085.Thu, Oct 31, 7:27 AM

Rise the dependence on KF5 to avoid #ifdef