Make KCModuleQml conform to the defaulted() signal
ClosedPublic
Actions

Authored by ervin on Oct 30 2019, 11:04 AM.

Details

Reviewers

Group Reviewers

Plasma
Frameworks

Commits

Summary

This new signal got introduced in KCModule, so we need to emit it at the
right time depending on the ConfigModule state.

Depends on D25069

Repository

R295 KCMUtils

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript

ervin requested review of this revision.Oct 30 2019, 11:04 AM

src/kcmoduleqml.cpp
80–82	needsSave emits the current state and then connects for changes representsDefaults only connects for changes I would expect them to match as they're doing equivalent things. It looks to me that it's this line that's somewhat pointless - we're in a constructor so only super classes could possibly have connected and we can see it doesn't. Can you confirm.

src/kcmoduleqml.cpp
80–82	Yes, I confirm this is pointless and why I didn't replicate that for defaulted.

This revision is now accepted and ready to land.Oct 30 2019, 1:54 PM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			src/kcmoduleqml.cpp (3 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	69040	87a9ee1		Oct 30 2019, 11:04 AM	★	★
Diff 2	69272	483d43a	R295:4dc999b9eba11d2bae822a74cbd5199e688293c4	Nov 4 2019, 1:56 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
cc677c20f96d	e996ee287b1e	87a9ee123346	Kevin Ottens	Make KCModuleQml conform to the defaulted() signal (Show More…)	Oct 30 2019, 10:59 AM

	Status	Author	Revision
	Closed	ervin	D25070 Make KCModuleQml conform to the defaulted() signal
	Closed	ervin	D25069 Adjust KCModule to also channel information about defaults