Differential D25063

Deprecate KAboutData::fromPluginMetaData, now there is KAboutPluginDialog
ClosedPublic
Actions

Authored by kossebau on Oct 30 2019, 12:28 AM.

Details

Reviewers
apol
dfaure
Group Reviewers
Frameworks
Commits
R244:e8f558f8b2c7: Deprecate KAboutData::fromPluginMetaData, now there is KAboutPluginDialog
Summary

Depends on D25058

Diff Detail

Repository
R244 KCoreAddons
Branch
deprecateaboutdatafromPluginMetaData
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 18336
Build 18354: arc lint + arc unit
kossebau created this revision.Oct 30 2019, 12:28 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptOct 30 2019, 12:28 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
kossebau requested review of this revision.Oct 30 2019, 12:28 AM
dfaure accepted this revision.Nov 20 2019, 8:47 AM
dfaure added inline comments.
src/lib/kaboutdata.h
478

typo: "Dialogso" -> "Dialog"

This revision is now accepted and ready to land.Nov 20 2019, 8:47 AM
Closed by commit R244:e8f558f8b2c7: Deprecate KAboutData::fromPluginMetaData, now there is KAboutPluginDialog (authored by kossebau). · Explain WhyNov 24 2019, 12:53 PM
This revision was automatically updated to reflect the committed changes.
kossebau marked an inline comment as done.Nov 24 2019, 12:55 PM

Revision Contents
Changeset List

PathPackages
Msrc/lib/CMakeLists.txt (2 lines)
Msrc/lib/kaboutdata.h (6 lines)
Msrc/lib/kaboutdata.cpp (2 lines)

Diff 69017

View Options

src/lib/CMakeLists.txt

Loading...
View Options

src/lib/kaboutdata.h

Loading...
View Options

src/lib/kaboutdata.cpp

Loading...