Forward x11 raw pointer buttons to PointerInputRedirection
ClosedPublic

Authored by graesslin on Aug 19 2016, 3:04 PM.

Details

Reviewers
mart
Group Reviewers
Plasma
KWin
Summary

The raw pointer button events intercepted in the XInput2 input filter
get sent through the Platform to the PointerInputRedirection. This
makes the PointerInputRedirection track the pointer button state and
emit the signals for button changed and axis changed.

These signals are used by the modifier-only shortcut detection to
determine whether the shortcut should trigger.

On X11 the "normal" input handling doesn't use the InputRedirection
and the emitted signals are not consumed by anything else. As
PointerInputRedirection is not inited the events are not forwarded
to the input filter, thus won't be processed by other parts and
won't interfere with the normal event processing on X11.

Given that it also doesn't matter that the input filter does not
apply the left-handed setting. The internal tracking will have a
wrong mouse button, but nothing is going to do decisions based on
the value of the pressed mouse button. For the moment all we are
interested in is that a button is pressed.

Test Plan

Pressed meta, clicked, scrolled, released meta: launcher
did not open. Pressed meta, released meta: launcher opened

Diff Detail

Repository
R108 KWin
Branch
x11-buttons-to-platform
Lint
No Linters Available
Unit
No Unit Test Coverage
graesslin updated this revision to Diff 6083.Aug 19 2016, 3:04 PM
graesslin retitled this revision from to Forward x11 raw pointer buttons to PointerInputRedirection.
graesslin updated this object.
graesslin edited the test plan for this revision. (Show Details)
graesslin added reviewers: KWin, Plasma.
Restricted Application added a project: KWin. · View Herald TranscriptAug 19 2016, 3:04 PM
Restricted Application added subscribers: kwin, plasma-devel. · View Herald Transcript
mart accepted this revision.Aug 25 2016, 8:42 AM
mart added a reviewer: mart.
This revision is now accepted and ready to land.Aug 25 2016, 8:42 AM
graesslin closed this revision.Aug 25 2016, 12:26 PM