Add string escape characters to PowerShell syntax.
ClosedPublic

Authored by zrax on Oct 29 2019, 6:30 PM.

Details

Summary

Powershell uses the syntax <char> or u{hex} as escape sequences within double-quoted strings. This adds highlighting support for both sequences to the PowerShell syntax.

Diff Detail

Repository
R216 Syntax Highlighting
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
zrax created this revision.Oct 29 2019, 6:30 PM
Restricted Application added projects: Kate, Frameworks. · View Herald TranscriptOct 29 2019, 6:30 PM
Restricted Application added subscribers: kde-frameworks-devel, kwrite-devel. · View Herald Transcript
zrax requested review of this revision.Oct 29 2019, 6:30 PM
zrax edited the summary of this revision. (Show Details)Oct 29 2019, 6:32 PM
zrax edited the summary of this revision. (Show Details)
zrax edited the summary of this revision. (Show Details)
dhaumann accepted this revision.Oct 29 2019, 6:54 PM
dhaumann added a subscriber: dhaumann.

Please commit.

This revision is now accepted and ready to land.Oct 29 2019, 6:54 PM
zrax added a comment.Oct 29 2019, 7:55 PM

I do not have a KDE developer account, so I cannot land the change myself presently.

cullmann requested changes to this revision.Oct 29 2019, 8:04 PM
cullmann added a subscriber: cullmann.

I can push it for you.
But I think it would be a good idea to have an unit test extended with the new supported syntax parts.
Could you add that?

This revision now requires changes to proceed.Oct 29 2019, 8:04 PM
zrax updated this revision to Diff 69010.Oct 29 2019, 9:18 PM
  • Add test case for new escape sequences to powershell autotest

Looks good to me.

Btw, you posted several patches over the last two years. You could also apply for a KDE contributor account and push yourself, if you want.

zrax updated this revision to Diff 69011.Oct 29 2019, 9:35 PM
  • Add test case for new escape sequences to powershell autotest
cullmann accepted this revision.Oct 29 2019, 9:38 PM

Looks good to me!
Thanks!

This revision is now accepted and ready to land.Oct 29 2019, 9:38 PM
This revision was automatically updated to reflect the committed changes.