Optimize support of scanners with different image sources or duplex unit
Needs ReviewPublic

Authored by antonarnold on Tue, Oct 29, 6:10 PM.

Details

Reviewers
sars
Group Reviewers
KDE Applications
Summary

The initial changeset of D24904 has been split into two seperate revisions.
This one addresses various bugs which may result in inconsistent scanner options.

Diff Detail

Repository
R382 KSane Library
Lint
Lint Skipped
Unit
Unit Tests Skipped
antonarnold requested review of this revision.Tue, Oct 29, 6:10 PM
antonarnold created this revision.

Can you re-add the BUG: keywords to the description for the bugs that this patch fixes? Thanks!

sars added a comment.Tue, Oct 29, 7:14 PM

Isn't the change in setOptVals() the only change needed for fixing the scan option order problem?

Looking forward to the next iteration :)

src/ksanewidget.cpp
106

no spaces in the signal/slot signatures

471

Is this a bug-fix or a mistake?

747

This could be simplified:

if (map.contains(foo)) {

if (setValue(foo, map[foo])) {
    ret++;
}
map.remove(foo);

}

936

looks like these are the same white-space changes as in the other review. This will lead to merge conflicts.

src/ksanewidget_p.cpp
1167

signal/slot signature without spaces...

src/options/ksaneoptcombo.cpp
334

maybe just remove the whole commented code and the comment.

352

This fix could have been a separate commit and review. (it has nothing to do with the reorganization of the restoration of the options)