diff --git a/src/core/copyjob.cpp b/src/core/copyjob.cpp --- a/src/core/copyjob.cpp +++ b/src/core/copyjob.cpp @@ -664,7 +664,7 @@ void CopyJobPrivate::slotSubError(ListJob *job, ListJob *subJob) { - const QUrl url = subJob->url(); + const QUrl &url = subJob->url(); qCWarning(KIO_CORE) << url << subJob->errorString(); Q_Q(CopyJob); @@ -991,7 +991,7 @@ m_bURLDirty = true; ListJob *newjob = listRecursive(src, KIO::HideProgressInfo); newjob->setUnrestricted(true); - q->connect(newjob, &ListJob::entries, q, [this](KIO::Job *job, KIO::UDSEntryList list) { + q->connect(newjob, &ListJob::entries, q, [this](KIO::Job *job, const KIO::UDSEntryList &list) { slotEntries(job, list); }); q->connect(newjob, &ListJob::subError, q, [this](KIO::ListJob *job, KIO::ListJob *subJob) { diff --git a/src/core/deletejob.cpp b/src/core/deletejob.cpp --- a/src/core/deletejob.cpp +++ b/src/core/deletejob.cpp @@ -438,7 +438,7 @@ return; } - const UDSEntry entry = statJob->statResult(); + const UDSEntry &entry = statJob->statResult(); // Is it a file or a dir ? const bool isLink = entry.isLink(); const bool isDir = entry.isDir(); diff --git a/src/core/kcoredirlister.cpp b/src/core/kcoredirlister.cpp --- a/src/core/kcoredirlister.cpp +++ b/src/core/kcoredirlister.cpp @@ -1548,7 +1548,7 @@ // Look at all dirs being listed/shown for (auto itu = itemsInUse.begin(), ituend = itemsInUse.end(); itu != ituend; ++itu) { DirItem *dir = itu.value(); - QUrl oldDirUrl(itu.key()); + const QUrl &oldDirUrl = itu.key(); qCDebug(KIO_CORE_DIRLISTER) << "itemInUse:" << oldDirUrl; // Check if this dir is oldUrl, or a subfolder of it if (oldDirUrl == oldUrl || oldUrl.isParentOf(oldDirUrl)) { @@ -1941,7 +1941,7 @@ auto itu = itemsInUse.begin(); const auto ituend = itemsInUse.end(); for (; itu != ituend; ++itu) { - const QUrl deletedUrl(itu.key()); + const QUrl &deletedUrl = itu.key(); if (dirUrl == deletedUrl || dirUrl.isParentOf(deletedUrl)) { affectedItems.append(deletedUrl); } diff --git a/src/core/slavebase.h b/src/core/slavebase.h --- a/src/core/slavebase.h +++ b/src/core/slavebase.h @@ -360,7 +360,7 @@ * Returns a QString from the config/meta-data information. * @since 5.64 */ - QString configValue(const QString &key, const QString &defaultValue=QString()) const; + QString configValue(const QString &key, const QString &defaultValue = QString()) const; #if KIOCORE_ENABLE_DEPRECATED_SINCE(5, 64) /** diff --git a/src/core/slaveinterface.cpp b/src/core/slaveinterface.cpp --- a/src/core/slaveinterface.cpp +++ b/src/core/slaveinterface.cpp @@ -279,7 +279,7 @@ stream >> m; if (m.contains(QLatin1String("ssl_in_use"))) { const QLatin1String ssl_("ssl_"); - const MetaData constM = m; + const MetaData &constM = m; for (MetaData::ConstIterator it = constM.lowerBound(ssl_); it != constM.constEnd(); ++it) { if (it.key().startsWith(ssl_)) { d->sslMetaData.insert(it.key(), it.value()); diff --git a/src/filewidgets/kdiroperator.cpp b/src/filewidgets/kdiroperator.cpp --- a/src/filewidgets/kdiroperator.cpp +++ b/src/filewidgets/kdiroperator.cpp @@ -1390,7 +1390,7 @@ if (mimeFilters.size() > 1) { mimeFilterPass = false; - const QUrl url = urls.constFirst(); + const QUrl &url = urls.constFirst(); QMimeDatabase mimeDataBase; QMimeType fileMimeType = mimeDataBase.mimeTypeForUrl(url); @@ -1414,7 +1414,7 @@ QDropEvent *evt = static_cast(event); const QList urls = KUrlMimeData::urlsFromMimeData(evt->mimeData(), KUrlMimeData::DecodeOptions::PreferLocalUrls); - const QUrl url = urls.constFirst(); + const QUrl &url = urls.constFirst(); // stat the url to get details KIO::StatJob *job = KIO::stat(url, KIO::HideProgressInfo); diff --git a/src/filewidgets/knewfilemenu.cpp b/src/filewidgets/knewfilemenu.cpp --- a/src/filewidgets/knewfilemenu.cpp +++ b/src/filewidgets/knewfilemenu.cpp @@ -1341,7 +1341,7 @@ if (files.isEmpty()) { d->m_newMenuGroup->setEnabled(false); } else { - QUrl firstUrl = files.first(); + const QUrl &firstUrl = files.first(); if (KProtocolManager::supportsWriting(firstUrl)) { d->m_newMenuGroup->setEnabled(true); if (d->m_newDirAction) { diff --git a/src/gui/faviconrequestjob.cpp b/src/gui/faviconrequestjob.cpp --- a/src/gui/faviconrequestjob.cpp +++ b/src/gui/faviconrequestjob.cpp @@ -139,7 +139,7 @@ void FavIconRequestJob::slotResult(KJob *job) { KIO::TransferJob *tjob = static_cast(job); - const QUrl iconUrl = tjob->url(); + const QUrl &iconUrl = tjob->url(); KIO::FavIconsCache *cache = KIO::FavIconsCache::instance(); if (!job->error()) { QBuffer buffer(&d->m_iconData); diff --git a/src/ioslaves/ftp/ftp.cpp b/src/ioslaves/ftp/ftp.cpp --- a/src/ioslaves/ftp/ftp.cpp +++ b/src/ioslaves/ftp/ftp.cpp @@ -1143,7 +1143,7 @@ // Check whether or not mkdir failed because // the directory already exists... if (ftpFolder(path)) { - const QString failedPath = path; + const QString &failedPath = path; // Change the directory back to what it was... (void) ftpFolder(currentPath); return Result::fail(ERR_DIR_ALREADY_EXIST, failedPath); @@ -1373,9 +1373,9 @@ tempurl.setPath(path); // take the clean one QString listarg; // = tempurl.directory(QUrl::ObeyTrailingSlash); QString parentDir; - QString filename = tempurl.fileName(); + const QString filename = tempurl.fileName(); Q_ASSERT(!filename.isEmpty()); - QString search = filename; + const QString &search = filename; // Try cwd into it, if it works it's a dir (and then we'll list the parent directory to get more info) // if it doesn't work, it's a file (and then we'll use dir filename) diff --git a/src/ioslaves/help/kio_help.cpp b/src/ioslaves/help/kio_help.cpp --- a/src/ioslaves/help/kio_help.cpp +++ b/src/ioslaves/help/kio_help.cpp @@ -98,7 +98,7 @@ { redirect = false; - const QString path = fname; + const QString &path = fname; QString result = langLookup(path); if (result.isEmpty()) { diff --git a/src/ioslaves/http/http.cpp b/src/ioslaves/http/http.cpp --- a/src/ioslaves/http/http.cpp +++ b/src/ioslaves/http/http.cpp @@ -135,7 +135,7 @@ // Document Origin domain QString a = url.host(); // Current request domain - QString b = fqdn; + const QString &b = fqdn; if (a == b) { return false; diff --git a/src/ioslaves/http/kcookiejar/kcookiejar.h b/src/ioslaves/http/kcookiejar/kcookiejar.h --- a/src/ioslaves/http/kcookiejar/kcookiejar.h +++ b/src/ioslaves/http/kcookiejar/kcookiejar.h @@ -317,7 +317,7 @@ * - KCookieReject, reject all cookies for _domain * - KCookieAsk, the user decides what to do with cookies for _domain */ - void setDomainAdvice(const QString &_domain, KCookieAdvice _advice); + void setDomainAdvice(const QString &domain, KCookieAdvice advice); /** * This function sets the advice for all cookies originating from diff --git a/src/ioslaves/http/kcookiejar/kcookiejar.cpp b/src/ioslaves/http/kcookiejar/kcookiejar.cpp --- a/src/ioslaves/http/kcookiejar/kcookiejar.cpp +++ b/src/ioslaves/http/kcookiejar/kcookiejar.cpp @@ -1098,9 +1098,8 @@ // This function sets the advice for all cookies originating from // _domain. // -void KCookieJar::setDomainAdvice(const QString &_domain, KCookieAdvice _advice) +void KCookieJar::setDomainAdvice(const QString &domain, KCookieAdvice _advice) { - QString domain(_domain); KHttpCookieList *cookieList = m_cookieDomains.value(domain); if (cookieList) { diff --git a/src/ioslaves/trash/tests/testtrash.cpp b/src/ioslaves/trash/tests/testtrash.cpp --- a/src/ioslaves/trash/tests/testtrash.cpp +++ b/src/ioslaves/trash/tests/testtrash.cpp @@ -418,7 +418,7 @@ } const QString fileName = QStringLiteral("testtrash-file"); const QString origFilePath = m_otherPartitionTopDir + fileName; - const QString fileId = fileName; + const QString &fileId = fileName; // cleanup QFile::remove(m_otherPartitionTrashDir + QLatin1String("/info/") + fileId + QLatin1String(".trashinfo")); QFile::remove(m_otherPartitionTrashDir + QLatin1String("/files/") + fileId); diff --git a/src/ioslaves/trash/trashimpl.cpp b/src/ioslaves/trash/trashimpl.cpp --- a/src/ioslaves/trash/trashimpl.cpp +++ b/src/ioslaves/trash/trashimpl.cpp @@ -1401,7 +1401,7 @@ bool deleteFurther = true; for (int i = 0; (i < infoList.count()) && deleteFurther; ++i) { - const QFileInfo info = infoList.at(i); + const QFileInfo &info = infoList.at(i); del(trashId, info.fileName()); // delete trashed file diff --git a/src/widgets/kdirmodel.cpp b/src/widgets/kdirmodel.cpp --- a/src/widgets/kdirmodel.cpp +++ b/src/widgets/kdirmodel.cpp @@ -492,7 +492,7 @@ //qDebug() << url; if (!urlsBeingFetched.isEmpty()) { - const QUrl dirUrl(url); + const QUrl &dirUrl = url; for (const QUrl &urlFetched : qAsConst(urlsBeingFetched)) { if (dirUrl.matches(urlFetched, QUrl::StripTrailingSlash) || dirUrl.isParentOf(urlFetched)) { //qDebug() << "Listing found" << dirUrl.url() << "which is a parent of fetched url" << urlFetched; diff --git a/src/widgets/kfileitemactions.cpp b/src/widgets/kfileitemactions.cpp --- a/src/widgets/kfileitemactions.cpp +++ b/src/widgets/kfileitemactions.cpp @@ -245,7 +245,7 @@ int KFileItemActions::addServiceActionsTo(QMenu *mainMenu) { const KFileItemList items = d->m_props.items(); - const KFileItem firstItem = items.first(); + const KFileItem &firstItem = items.first(); const QString protocol = firstItem.url().scheme(); // assumed to be the same for all items const bool isLocal = !firstItem.localPath().isEmpty(); const bool isSingleLocal = items.count() == 1 && isLocal; @@ -608,7 +608,7 @@ //// Ok, we have everything, now insert const KFileItemList items = d->m_props.items(); - const KFileItem firstItem = items.first(); + const KFileItem &firstItem = items.first(); const bool isLocal = firstItem.url().isLocalFile(); // "Open With..." for folders is really not very useful, especially for remote folders. // (media:/something, or trash:/, or ftp://...) diff --git a/src/widgets/kpropertiesdialog.cpp b/src/widgets/kpropertiesdialog.cpp --- a/src/widgets/kpropertiesdialog.cpp +++ b/src/widgets/kpropertiesdialog.cpp @@ -385,7 +385,7 @@ bool modal) { if (_items.count() == 1) { - const KFileItem item = _items.first(); + const KFileItem &item = _items.first(); if (item.entry().count() == 0 && item.localPath().isEmpty()) // this remote item wasn't listed by a slave // Let's stat to get more info on the file { @@ -2723,7 +2723,7 @@ return false; } - const KFileItem item = items.first(); + const KFileItem &item = items.first(); return item.isFile() && !item.localPath().isEmpty() && item.isReadable() && !item.isDesktopFile() && !item.isLink(); } @@ -3088,7 +3088,7 @@ if (_items.count() != 1) { return false; } - const KFileItem item = _items.first(); + const KFileItem &item = _items.first(); // check if desktop file if (!item.isDesktopFile()) { return false; @@ -3389,7 +3389,7 @@ if (_items.count() != 1) { return false; } - const KFileItem item = _items.first(); + const KFileItem &item = _items.first(); // check if desktop file if (!item.isDesktopFile()) { return false; @@ -3902,7 +3902,7 @@ return false; } - const KFileItem item = _items.first(); + const KFileItem &item = _items.first(); // check if desktop file if (!item.isDesktopFile()) { diff --git a/src/widgets/krun.cpp b/src/widgets/krun.cpp --- a/src/widgets/krun.cpp +++ b/src/widgets/krun.cpp @@ -831,7 +831,7 @@ return false; } - const QString bin = args.first(); + const QString &bin = args.first(); return KRun::runCommand(cmd, bin, bin /*iconName*/, window, QByteArray(), workingDirectory); }