Differential D25028

Make the search box more compact
ClosedPublic
Actions

Authored by iasensio on Oct 29 2019, 12:24 AM.

Details

Reviewers
elvisangelaccio
ngraham
Group Reviewers
Dolphin
VDG
Commits
R318:7949aee2d252: Make the search box more compact
Summary

Reduce the spacing between widgets and remove the content margins on the extended search options to have a more compact and space-saving layout.
Currently, some widgets are not even aligned.
This will be even more important if we remove the toggle button for 'More Options'.

CCBUG: 386754

Test Plan

BEFORE:


AFTER:

Diff Detail

Repository
R318 Dolphin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
iasensio created this revision.Oct 29 2019, 12:24 AM
Restricted Application added a project: Dolphin. · View Herald TranscriptOct 29 2019, 12:24 AM
Restricted Application added a subscriber: kfm-devel. · View Herald Transcript
iasensio requested review of this revision.Oct 29 2019, 12:24 AM
ngraham accepted this revision.Oct 29 2019, 1:35 AM
This revision is now accepted and ready to land.Oct 29 2019, 1:35 AM
elvisangelaccio requested changes to this revision.Nov 2 2019, 12:14 PM
elvisangelaccio added inline comments.
src/search/dolphinfacetswidget.cpp
68

Please do not hardcode numbers in the code. Use a variable in global.h instead, where we already have a VERTICAL_SPACER_HEIGHT constant.

This revision now requires changes to proceed.Nov 2 2019, 12:14 PM
iasensio updated this revision to Diff 69210.Nov 3 2019, 11:30 AM
  • New constant in header instead of hardcoded value in code
iasensio marked an inline comment as done.Nov 3 2019, 11:36 AM
src/search/dolphinfacetswidget.cpp
68

VERTICAL_SPACER_HEIGHT is unfortunately too wide for this (18px). It seems to be used only in the properties dialog to separate groups of properties using a QSpacerItem.
In the same fashion I've added a SMALL_LAYOUT_SPACING, but only for this local scope, in`dolphinsearchbox.h`.

elvisangelaccio added inline comments.Nov 3 2019, 9:59 PM
src/search/dolphinfacetswidget.cpp
68

I meant to put the new constant in global.h, not to use VERTICAL_SPACER_HEIGHT ;)

iasensio updated this revision to Diff 69244.Nov 3 2019, 11:40 PM
iasensio marked 3 inline comments as done.
  • Move spacing constant to global.h
iasensio added inline comments.Nov 3 2019, 11:42 PM
src/search/dolphinfacetswidget.cpp
68

Oh, fool me 😄

This revision is now accepted and ready to land.Nov 6 2019, 8:33 PM
Closed by commit R318:7949aee2d252: Make the search box more compact (authored by iasensio). · Explain WhyNov 7 2019, 12:51 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 69370

View Options

src/global.h

Loading...
View Options

src/search/dolphinfacetswidget.cpp

Loading...
View Options

src/search/dolphinsearchbox.cpp

Loading...