fix: create control files only when needed
ClosedPublic

Authored by romangg on Mon, Oct 28, 9:28 PM.

Details

Summary

This way the control directory is only created when a control file becomes
necessary. In case of default values control files are without information.
These files are then deleted.

FIXED-IN: 5.17.3

Test Plan

Started Wayland session without writing a file and gets created when control
needs to be written.

Diff Detail

Repository
R104 KScreen
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
romangg created this revision.Mon, Oct 28, 9:28 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMon, Oct 28, 9:28 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
romangg requested review of this revision.Mon, Oct 28, 9:28 PM
romangg edited the summary of this revision. (Show Details)Mon, Oct 28, 9:30 PM
davidedmundson added inline comments.
common/control.cpp
224

who would now makes this folder?

ControlConfig has a line to do so, but ControlOutput does not.

I can't see a line in config.cpp (though I'm not 100% sure where ControlOutput is currently used)

romangg added inline comments.Fri, Nov 8, 8:12 AM
common/control.cpp
224

ControlOutput is currently not used, just a stub. At some point I want to add the "auto" value for refresh rate and so on to that.

This revision was not accepted when it landed; it landed in state Needs Review.Mon, Nov 11, 8:56 PM
This revision was automatically updated to reflect the committed changes.