[KIO::stat] Add a KF6 TODO to make details a Bitmask
AbandonedPublic

Authored by meven on Oct 28 2019, 9:23 AM.

Details

Reviewers
dfaure
Group Reviewers
Frameworks

Diff Detail

Repository
R241 KIO
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 18248
Build 18266: arc lint + arc unit
meven created this revision.Oct 28 2019, 9:23 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptOct 28 2019, 9:23 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
meven requested review of this revision.Oct 28 2019, 9:23 AM
apol added a subscriber: apol.Oct 28 2019, 12:43 PM

you may want to explain a bit more what you mean there.
it could make sense to keep the TODO in the .cpp file, no need to get it on every user

Instead of the TODO one could already add an overload of the method now, and deprecate the current one. So that in KF6 times the deprecated could be dumped, and there would just be the preferred variant.

meven added a comment.Oct 28 2019, 1:25 PM

Instead of the TODO one could already add an overload of the method now, and deprecate the current one. So that in KF6 times the deprecated could be dumped, and there would just be the preferred variant.

Nice idea

It's actually an approach to be preferred in such cases, as it moves some of the work to be done at creating KF6 and porting to its new API for users of KF to now and the time span until KF6, keeping the unavoidable hurdle at the actual KF5->KF6 change as small as possible.