Differential D24998

Fix ksysguard acpi cooling devices
ClosedPublic
Actions

Authored by jjorge on Oct 28 2019, 9:02 AM.

Details

Reviewers
davidedmundson
Commits
R106:86def1d13e84: Fix ksysguard acpi cooling devices
Summary

The cooling devices state never changed from zero. It was wrongly calculated as a fraction from 0 to 1, instead of a percentage.

Diff Detail

Repository
R106 KSysguard
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
jjorge created this revision.Oct 28 2019, 9:02 AM
Restricted Application added a project: Plasma. · View Herald TranscriptOct 28 2019, 9:02 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
jjorge requested review of this revision.Oct 28 2019, 9:02 AM
jjorge added a comment.Oct 28 2019, 9:04 AM

How to test : just add an ACPI cooling device to ksysguard, it would always show 0% before this patch. To find one cooling device that actually changes, you can use the 'acpi -V' command

davidedmundson accepted this revision.Oct 28 2019, 11:02 AM
This revision is now accepted and ready to land.Oct 28 2019, 11:02 AM
ngraham added a subscriber: ngraham.Oct 28 2019, 4:53 PM

Nice work.

BTW you might want to clean up the name in your .gitconfig file. It's currently set to "José JORGE [zezinho]". Just "José Jorge" would be better. :)

Closed by commit R106:86def1d13e84: Fix ksysguard acpi cooling devices (authored by jjorge, committed by ngraham). · Explain WhyOct 28 2019, 4:57 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mksysguardd/Linux/acpi.c (2 lines)

Diff 68895

View Options

ksysguardd/Linux/acpi.c

Loading...