support multiple rcc files with icons themes
AbandonedPublic

Authored by cullmann on Oct 27 2019, 7:01 PM.

Details

Reviewers
vonreth
dfaure
Group Reviewers
Frameworks
Summary

Instead of one hard-coded theme, support multiple ones
This assumes that the rccs themself contain a /icons/<themename> prefix

Test Plan

Compiles and finds my local stuff

Diff Detail

Repository
R302 KIconThemes
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 18237
Build 18255: arc lint + arc unit
cullmann created this revision.Oct 27 2019, 7:01 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptOct 27 2019, 7:01 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
cullmann requested review of this revision.Oct 27 2019, 7:01 PM

To make this usable, we will need to change the way we create the binary resources in breeze-icons and adapt the craft packaging.
Then we can use e.g. breeze + breeze dark for app store applications like normally.
We might want to alter this later to use libs to have mmap on all architectures.

vonreth requested changes to this revision.Oct 27 2019, 7:19 PM
vonreth added a subscriber: dfaure.

Rest looks good to me.
@dfaure you created the initial version what do you think?

src/kicontheme.cpp
79

I guess we can use an Initializer here

This revision now requires changes to proceed.Oct 27 2019, 7:19 PM

Will alter the initializer before pushing, if it is clarified if the approach is ok.
Given the lack of mmap for resource files on Windows, I actually would prefer to hide the resources in dummy plugins, but I guess it would make sense to do this in a second step.

cullmann abandoned this revision.Nov 2 2019, 4:04 PM

I think I retract this. I have a nicer way to have this seamless integrated without KIconThemes.