Differential D24988

[kcmkwin/desktop] Elide "Show animation when switching" checkbox text
ClosedPublic
Actions

Authored by ngraham on Oct 27 2019, 6:53 PM.

Details

Reviewers
zzag
davidedmundson
Group Reviewers
KWin
Commits
R108:105976a42a25: [kcmkwin/desktop] Elide "Show animation when switching" checkbox text
Summary

Otherwise the combobox containing the switching effects escapes from the page. Same fix
as D24885.

BUG: 403151
FIXED-IN: 5.17.2

Test Plan

Checkbox text now elides when the window is made very narrow, and combobox no longer gets
cut off.

Diff Detail

Repository
R108 KWin
Branch
elide-text-rather-than-cutting-off-combobox (branched from Plasma/5.17)
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 18236
Build 18254: arc lint + arc unit
ngraham created this revision.Oct 27 2019, 6:53 PM
Restricted Application added a project: KWin. · View Herald TranscriptOct 27 2019, 6:53 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
ngraham requested review of this revision.Oct 27 2019, 6:53 PM
zzag accepted this revision.Oct 28 2019, 9:49 AM
This revision is now accepted and ready to land.Oct 28 2019, 9:49 AM
zzag retitled this revision from [kcmkwin/kwinvirtualdesktops] Elide "Show animation when switching" checkbox text to [kcmkwin/desktop] Elide "Show animation when switching" checkbox text.Oct 28 2019, 9:51 AM
davidedmundson accepted this revision.Oct 28 2019, 10:09 AM
Closed by commit R108:105976a42a25: [kcmkwin/desktop] Elide "Show animation when switching" checkbox text (authored by ngraham). · Explain WhyOct 28 2019, 1:57 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 68845

View Options

kcmkwin/kwindesktop/package/contents/ui/main.qml

Loading...