Port away from I18N_NOOP2 and KLocalizedString::insertQtDomain
ClosedPublic

Authored by dfaure on Oct 26 2019, 3:59 PM.

Details

Summary
  • Remove duplication of the untranslated (but marked for translation)

string. "Home" is "Home" even after marking for translation, no need to pass
it twice. Pass the context (so I18NC_NOOP can be used) and discard it.

  • Messages.sh covers all of kio, there's no Qt linguist file involved

here.

Test Plan

Builds, and the file places widget looks ok in Dolphin,
both in English and in French (LC_ALL=fr_FR dolphin).

Diff Detail

Repository
R241 KIO
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 18199
Build 18217: arc lint + arc unit
dfaure created this revision.Oct 26 2019, 3:59 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptOct 26 2019, 3:59 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
dfaure requested review of this revision.Oct 26 2019, 3:59 PM
aacid accepted this revision.Oct 27 2019, 4:45 PM
This revision is now accepted and ready to land.Oct 27 2019, 4:45 PM
dfaure closed this revision.Oct 27 2019, 5:41 PM