Differential D24964

[applets/weather] Port from KIconLoader to QIcon
ClosedPublic
Actions

Authored by iasensio on Oct 26 2019, 12:51 PM.

Details

Reviewers
ngraham
Group Reviewers
Plasma
Maniphest Tasks
T11637: KIconThemes Cleanups
Commits
R114:dc40abfa9cfa: [applets/weather] Port from KIconLoader to QIcon
Summary

KIconLoader was used only to check if the iconName is valid.
This patch uses QIcon::hasThemeIcon() instead.
It might help T11637 a little.

Test Plan

No behavior changes

Diff Detail

Repository
R114 Plasma Addons
Branch
weather_qicon
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 18193
Build 18211: arc lint + arc unit
iasensio created this revision.Oct 26 2019, 12:51 PM
Restricted Application added a project: Plasma. · View Herald TranscriptOct 26 2019, 12:51 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
iasensio requested review of this revision.Oct 26 2019, 12:51 PM
ngraham accepted this revision.Oct 26 2019, 1:52 PM
This revision is now accepted and ready to land.Oct 26 2019, 1:52 PM
Closed by commit R114:dc40abfa9cfa: [applets/weather] Port from KIconLoader to QIcon (authored by iasensio, committed by ngraham). · Explain WhyOct 27 2019, 8:31 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mapplets/weather/plugin/util.cpp (6 lines)

Diff 68787

View Options

applets/weather/plugin/util.cpp

Loading...