[notifications] Center no notification text on mobile

Authored by nicolasfella on Oct 24 2019, 8:49 PM.



Keep it as before on the desktop to be consistent with the other plasmoids

Test Plan

run plasmashell with/without QT_QUICK_CONTROLS_MOBILE

Diff Detail

R120 Plasma Workspace
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
nicolasfella created this revision.Oct 24 2019, 8:49 PM
Restricted Application added a project: Plasma. · View Herald TranscriptOct 24 2019, 8:49 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
nicolasfella requested review of this revision.Oct 24 2019, 8:49 PM
nicolasfella edited the summary of this revision. (Show Details)Oct 24 2019, 8:51 PM
nicolasfella edited the test plan for this revision. (Show Details)
nicolasfella added reviewers: Plasma, VDG.

Could you add a rounded corners?

broulik requested changes to this revision.Oct 24 2019, 9:21 PM
broulik added a subscriber: broulik.

Keep the width and enable wrapping and horizontal centering. We both know how wide some locale can get :)

This revision now requires changes to proceed.Oct 24 2019, 9:21 PM
  • Do as Kai says

Looks just more complicated to me, but :shrug:

broulik accepted this revision.Oct 24 2019, 9:33 PM

Fix it, then ship it




Only vertical center now, please

This revision is now accepted and ready to land.Oct 24 2019, 9:33 PM
This revision was automatically updated to reflect the committed changes.
broulik added inline comments.Oct 24 2019, 9:51 PM

Now you could have used an anchors.fill xD

mart added a subscriber: mart.Oct 25 2019, 11:59 AM

I'm fine with it, however...
there must be a bug somewhere in the shell, because the whole notification applet is supposed to be invisible when there are none, i have to investigate into that