Port KSSLD internals from KSslError to QSslError
ClosedPublic

Authored by vkrause on Oct 24 2019, 5:22 PM.

Details

Summary

The strings don't match all enum values exactly, as this tries to keep
the same strings for the corresponding enums from KSslError as mapped
in ktcpsocket.cpp.

Mistakes to do this correctly (or the eventual move to QMetaEnum from
QSslError) however are not dangerous, it will merely result in the user
being asked to confirm ignoring the (now more precise) error again, we
will not silently ignore errors we shouldn't be ignoring.

Diff Detail

Repository
R241 KIO
Branch
next
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 18140
Build 18158: arc lint + arc unit
vkrause created this revision.Oct 24 2019, 5:22 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptOct 24 2019, 5:22 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
vkrause requested review of this revision.Oct 24 2019, 5:22 PM
aacid accepted this revision.Oct 24 2019, 6:44 PM
This revision is now accepted and ready to land.Oct 24 2019, 6:44 PM
vkrause retitled this revision from Port KSSD internals from KSslError to QSslError to Port KSSLD internals from KSslError to QSslError.Oct 25 2019, 2:30 PM
This revision was automatically updated to reflect the committed changes.