KCM KSplash port to ManagedConfigModule
ClosedPublic

Authored by crossi on Oct 24 2019, 2:15 PM.

Diff Detail

Repository
R119 Plasma Desktop
Lint
Lint Skipped
Unit
Unit Tests Skipped
Build Status
Buildable 18156
Build 18174: arc lint + arc unit
crossi created this revision.Oct 24 2019, 2:15 PM
Restricted Application added a project: Plasma. · View Herald TranscriptOct 24 2019, 2:15 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
crossi requested review of this revision.Oct 24 2019, 2:15 PM
davidedmundson added inline comments.
kcms/ksplash/kcm.cpp
136

doesn't managed module take care of this?

crossi added inline comments.Oct 24 2019, 3:25 PM
kcms/ksplash/kcm.cpp
136

it needs an explicit call, like load() and save()

crossi added inline comments.Oct 24 2019, 3:34 PM
kcms/ksplash/kcm.cpp
136

My bad. setNeedsSave() is no longer needed.

crossi updated this revision to Diff 68699.Oct 24 2019, 3:37 PM

setNeedsSave() not needed

crossi updated this revision to Diff 68734.Oct 25 2019, 9:25 AM

Remove unnecessary override

davidedmundson accepted this revision.Oct 25 2019, 9:31 AM
This revision is now accepted and ready to land.Oct 25 2019, 9:31 AM
ervin accepted this revision.Oct 25 2019, 12:56 PM
This revision was automatically updated to reflect the committed changes.