Use more return early
ClosedPublic

Authored by nicolasfella on Oct 24 2019, 2:00 PM.

Diff Detail

Repository
R116 Plasma Network Management Applet
Branch
ret
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 18128
Build 18146: arc lint + arc unit
nicolasfella created this revision.Oct 24 2019, 2:00 PM
Restricted Application added a project: Plasma. · View Herald TranscriptOct 24 2019, 2:00 PM
Restricted Application added a reviewer: jgrulich. · View Herald Transcript
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
nicolasfella requested review of this revision.Oct 24 2019, 2:00 PM
crossi requested changes to this revision.Oct 24 2019, 2:22 PM
crossi added a subscriber: crossi.
crossi added inline comments.
libs/models/networkmodel.cpp
402–404

Code style : Use curly braces even when the body of a conditional statement contains only one line.

This revision now requires changes to proceed.Oct 24 2019, 2:22 PM
jgrulich accepted this revision.Oct 24 2019, 3:10 PM
jgrulich added inline comments.
libs/models/networkmodel.cpp
402–404

I think this is a valid Qt coding style, it was just my obsession to use curly braces everywhere, even for single line body.

  • Conding style
crossi resigned from this revision.Oct 24 2019, 3:14 PM
crossi added inline comments.
libs/models/networkmodel.cpp
402–404

That's a good obsession and help a lot to avoid error . ;)

This revision is now accepted and ready to land.Oct 24 2019, 3:14 PM
nicolasfella added inline comments.Oct 24 2019, 3:15 PM
libs/models/networkmodel.cpp
402–404
This revision was automatically updated to reflect the committed changes.