KCM Style port to KConfigXT
ClosedPublic

Authored by crossi on Oct 24 2019, 12:02 PM.

Details

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
crossi created this revision.Oct 24 2019, 12:02 PM
Restricted Application added a project: Plasma. · View Herald TranscriptOct 24 2019, 12:02 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
crossi requested review of this revision.Oct 24 2019, 12:02 PM
ervin requested changes to this revision.Oct 25 2019, 1:50 PM
ervin added inline comments.
kcms/style/kcmstyle.cpp
314

That line and the metaenum wrangling could likely be factored out somehow and shared with load(). Especially the enum part is uncommon enough that we probably want to hide it behind a nicer name (also would help a bit having a more consistent level of abstraction in the code of those functions).

kcms/style/kcmstyle.h
48

Please have the space before the * and not after to follow the style of that file (see the Q_PROPERTY just above).

66

ditto

This revision now requires changes to proceed.Oct 25 2019, 1:50 PM
crossi updated this revision to Diff 68978.Oct 29 2019, 2:16 PM

Move some duplicated code to a function

ervin accepted this revision.Oct 30 2019, 12:14 PM
This revision is now accepted and ready to land.Oct 30 2019, 12:14 PM
This revision was automatically updated to reflect the committed changes.