Use return early
ClosedPublic

Authored by nicolasfella on Oct 23 2019, 9:55 PM.

Details

Summary

Makes the code more readable by reducing the indentation depth

Diff Detail

Repository
R116 Plasma Network Management Applet
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
nicolasfella created this revision.Oct 23 2019, 9:55 PM
Restricted Application added a project: Plasma. · View Herald TranscriptOct 23 2019, 9:55 PM
Restricted Application added a reviewer: jgrulich. · View Herald Transcript
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
nicolasfella requested review of this revision.Oct 23 2019, 9:55 PM
jgrulich accepted this revision.Oct 24 2019, 5:28 AM
This revision is now accepted and ready to land.Oct 24 2019, 5:28 AM

I think all of thise breaks in loops must be continues?

libs/models/networkmodel.cpp
457

Shouldn't this be a continue?

846

continue?

I think all of thise breaks in loops must be continues?

Good catch.

jgrulich requested changes to this revision.Oct 24 2019, 10:14 AM
This revision now requires changes to proceed.Oct 24 2019, 10:14 AM
  • s/break/continue
  • Fixup
jgrulich accepted this revision.Oct 24 2019, 10:24 AM
This revision is now accepted and ready to land.Oct 24 2019, 10:24 AM
This revision was automatically updated to reflect the committed changes.