Don't reset model when activeconnectionstate changed
ClosedPublic
Actions

Authored by nicolasfella on Oct 23 2019, 9:33 PM.

Details

Reviewers

Commits

Summary

resetting the model when a single property changes is using a sledgehammer to crack a nut. emitting dataChanged for the affected row is enough.

Test Plan

(de)activated connections in plasmoid and mobile wifi KCM.
Verified with hotspot that lots of calls to modelReset disappeared

Repository

R116 Plasma Network Management Applet

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Restricted Application added a reviewer: jgrulich. · View Herald Transcript

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

nicolasfella requested review of this revision.Oct 23 2019, 9:33 PM

This revision is now accepted and ready to land.Oct 24 2019, 5:24 AM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			libs/models/networkmodel.cpp (5 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	68643	cca7e8d		Oct 23 2019, 9:33 PM	★	★
Diff 2	68656	5e9ff38	R116:4627aaf6f066919aea81ad26dcaae37fb313833c	Oct 24 2019, 10:15 AM	★	★