Don't reset model when activeconnectionstate changed
ClosedPublic
Actions

Authored by nicolasfella on Oct 23 2019, 9:33 PM.

Details

Reviewers

Commits

R116:4627aaf6f066: Don't reset model when activeconnectionstate changed

Summary

resetting the model when a single property changes is using a sledgehammer to crack a nut. emitting dataChanged for the affected row is enough.

Test Plan

(de)activated connections in plasmoid and mobile wifi KCM.
Verified with hotspot that lots of calls to modelReset disappeared

Diff Detail

Repository

R116 Plasma Network Management Applet

Branch

activeconn

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 18095
Build 18113: arc lint + arc unit

nicolasfella created this revision.Oct 23 2019, 9:33 PM

Restricted Application added a project: Plasma. · View Herald TranscriptOct 23 2019, 9:33 PM

Restricted Application added a reviewer: jgrulich. · View Herald Transcript

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

nicolasfella requested review of this revision.Oct 23 2019, 9:33 PM

Harbormaster completed remote builds in B18095: Diff 68643.Oct 23 2019, 9:33 PM

jgrulich accepted this revision.Oct 24 2019, 5:24 AM

This revision is now accepted and ready to land.Oct 24 2019, 5:24 AM

Closed by commit R116:4627aaf6f066: Don't reset model when activeconnectionstate changed (authored by nicolasfella). · Explain WhyOct 24 2019, 10:15 AM

This revision was automatically updated to reflect the committed changes.

nicolasfella mentioned this in D24919: Don't reset model when device state changes.Oct 24 2019, 1:27 PM

nicolasfella mentioned this in D24924: Don't reset model when adding an active connection.Oct 24 2019, 2:09 PM

nicolasfella mentioned this in R116:6929300787ac: Don't reset model when adding an active connection.Oct 24 2019, 3:33 PM

nicolasfella mentioned this in R116:2bb496b0708f: Don't reset model when device state changes.

Revision Contents
Changeset List

			Path	Packages
M			libs/models/networkmodel.cpp (5 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	68643	cca7e8d		Oct 23 2019, 9:33 PM	★	★
Diff 2	68656	5e9ff38	R116:4627aaf6f066919aea81ad26dcaae37fb313833c	Oct 24 2019, 10:15 AM	★	★

Commit	Tree	Parents	Author	Summary	Date
aef5fcf7f015	0f7ca8f4a7b2	cca7e8d08d42	Nicolas Fella	Don't reset model when activeconnectionstate changed (Show More…)	Oct 23 2019, 9:30 PM

Diff 68643

View Options

libs/models/networkmodel.cpp