notifier: Make action buttons translatable
ClosedPublic

Authored by aspotashev on Oct 23 2019, 7:42 PM.

Diff Detail

Repository
R134 Discover Software Store
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
aspotashev created this revision.Oct 23 2019, 7:42 PM
Restricted Application added a project: Plasma. · View Herald TranscriptOct 23 2019, 7:42 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
aspotashev requested review of this revision.Oct 23 2019, 7:42 PM
aspotashev updated this revision to Diff 68625.Oct 23 2019, 7:43 PM

oops, sent wrong patch

broulik accepted this revision.EditedOct 24 2019, 8:07 AM
broulik added a subscriber: broulik.

Plasma/5.17 branch please. While you cannot change strings, you can make previously accidentally untranslated strings translatable.

This revision is now accepted and ready to land.Oct 24 2019, 8:07 AM
apol accepted this revision.Oct 24 2019, 11:00 AM

Good catch! I wonder how that happened :/

This revision was automatically updated to reflect the committed changes.

A similar issue can be found in libdiscover/bakcends/PackageKitBackend/PackageKitNotifier.cpp:141:

https://cgit.kde.org/discover.git/tree/libdiscover/backends/PackageKitBackend/PackageKitNotifier.cpp#n141

Can it be fixed as well?

Thanks in advance for your answer.

A similar issue can be found in libdiscover/bakcends/PackageKitBackend/PackageKitNotifier.cpp:141:

https://cgit.kde.org/discover.git/tree/libdiscover/backends/PackageKitBackend/PackageKitNotifier.cpp#n141

Can it be fixed as well?

Thanks in advance for your answer.

I will fix this.

A similar issue can be found in libdiscover/bakcends/PackageKitBackend/PackageKitNotifier.cpp:141:

https://cgit.kde.org/discover.git/tree/libdiscover/backends/PackageKitBackend/PackageKitNotifier.cpp#n141

Can it be fixed as well?

Thanks in advance for your answer.

fixed