This allows to use it for a slideshow or something.
Details
Details
- Reviewers
ngraham - Group Reviewers
Plasma VDG - Commits
- R120:56a43f8ee0ad: [Lock Screen] Add option to hide clock when idle
Option is on by default as before.
Clock hides in unison with the rest of the UI when unchecked.
Question is what about the mouse cursor? I think it should just always hide when idle (no config option) but there was a Qt bug where MouseArea wouldn't apply the cursorShape which was since fixed: https://bugreports.qt.io/browse/QTBUG-41045
So we could resurrect D13207 now but without hacks :) I would do this separately from this patch
Diff Detail
Diff Detail
- Repository
- R120 Plasma Workspace
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
This should make a lot of people happy. :)
Is there a way to suppress these settings when you're using a theme that doesn't make the clock and media controls optional?
| lookandfeel/contents/lockscreen/config.qml | ||
|---|---|---|
| 5–6 | Make this a FormLayout since it now has multiple rows of items in it | |
Comment Actions
Is there a way to suppress these settings when you're using a theme that doesn't make the clock and media controls optional?
That's the trick! The config comes *from the theme* (similar to how plasmoids do it), so only our theme will have those check boxes.
| lookandfeel/contents/lockscreen/config.qml | ||
|---|---|---|
| 5–6 | Can't, really, as it has to be aligned wit the non QML bits and other UI elements out of the control of this item (see formAlignment comment) | |
| lookandfeel/contents/components/WallpaperFader.qml | ||
|---|---|---|
| 145–149 | Why are we changing this line? | |
| lookandfeel/contents/lockscreen/config.qml | ||
| 21 | One thing Thomas always used to say was that if you have a checkbox it should be obvious what the opposite action is. This currently sounds like if it's off, the clock will randomly start flashing like a 90's html <blink> tag. | |
Comment Actions
Instead of explicitly talking about clockwhat about a "Only show wallpaper when idle?"
Comment Actions
Given that the setting will be off by default, its opposite state is clear enough I'd say. It's not the best string ever, but maybe we should start with this and massage it later or else this will probably be stuck in limbo forever...
Comment Actions
Does it make sense to have the option off by default, i.e. hiding the clock on idle by default?
I'd expect expect more users wanting to see the clock than users being annoyed by it (with the majority probably not caring either way), tbh. The slideshow is a very valid usecase for hiding it, but do we expect more users to have a slidehsow on their lock screen than users liking to always have a clock there?
Why not changing it to "Hide after X seconds of inactivity" and having it off by default?
Comment Actions
Does it make sense to have the option off by default, i.e. hiding the clock on idle by default?
"Given that the setting will be off by default," is not true. By default the clock is shown, so nothing changes here, also given a static image is also our default.