Differential D24889

Remove pointless textColor assignment
ClosedPublic
Actions

Authored by broulik on Oct 23 2019, 1:25 PM.

Details

Reviewers
ngraham
apol
Group Reviewers
Plasma
Commits
R112:0e61b5053180: Remove pointless textColor assignment
Summary

This is all handled by PlasmaComponents.Label which also honors any ColorScope around it.

Test Plan
  • Placed the view in a complementary colorgroup on a dark background, could still read text. Before I couldnt

Diff Detail

Repository
R112 Milou
Lint
Lint Skipped
Unit
Unit Tests Skipped
broulik created this revision.Oct 23 2019, 1:25 PM
Restricted Application added a project: Plasma. · View Herald TranscriptOct 23 2019, 1:25 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Oct 23 2019, 1:25 PM
ngraham accepted this revision.Oct 23 2019, 1:35 PM
This revision is now accepted and ready to land.Oct 23 2019, 1:35 PM
apol accepted this revision.Oct 23 2019, 1:44 PM
Closed by commit R112:0e61b5053180: Remove pointless textColor assignment (authored by broulik). · Explain WhyOct 23 2019, 1:47 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 68603

View Options

lib/qml/ResultDelegate.qml

Loading...
View Options

lib/qml/ResultsListViewDelegate.qml

Loading...