[kcmkwin/kwindecoration] Elide "theme default border size" CheckBox
ClosedPublic

Authored by broulik on Wed, Oct 23, 11:36 AM.

Details

Summary

Otherwise the layout explodes.
Unfortunately it seems Layouts don't shrink the items within even if there's not enough room at all, so I need this fillWidth + maximumWidth workaround.

Test Plan

Ideally, we'd wrap into a separate line or something but this requires more refactoring as a RowLayout can't do that on the spot, and a Flow doesn't give us the nice auto-sizing capabilities of a Layout :(
For 5.17 this is better than exploding the grid view outside visible bounds
Before


After

"Get new decorations" button is still on the right if there's enough room

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Wed, Oct 23, 11:36 AM
Restricted Application added a project: KWin. · View Herald TranscriptWed, Oct 23, 11:36 AM
Restricted Application added a subscriber: kwin. · View Herald Transcript
broulik requested review of this revision.Wed, Oct 23, 11:36 AM
broulik edited the test plan for this revision. (Show Details)
davidedmundson accepted this revision.Wed, Oct 23, 11:45 AM
davidedmundson added a subscriber: davidedmundson.

Not ideal, but better than before.

This revision is now accepted and ready to land.Wed, Oct 23, 11:45 AM
This revision was automatically updated to reflect the committed changes.