Differential D24885

[kcmkwin/kwindecoration] Elide "theme default border size" CheckBox
ClosedPublic
Actions

Authored by broulik on Oct 23 2019, 11:36 AM.

Details

Reviewers
davidedmundson
Group Reviewers
KWin
Commits
R108:2ce1d9922111: [kcmkwin/kwindecoration] Elide "theme default border size" CheckBox
Summary

Otherwise the layout explodes.
Unfortunately it seems Layouts don't shrink the items within even if there's not enough room at all, so I need this fillWidth + maximumWidth workaround.

Test Plan

Ideally, we'd wrap into a separate line or something but this requires more refactoring as a RowLayout can't do that on the spot, and a Flow doesn't give us the nice auto-sizing capabilities of a Layout :(
For 5.17 this is better than exploding the grid view outside visible bounds
Before


After

"Get new decorations" button is still on the right if there's enough room

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Oct 23 2019, 11:36 AM
Restricted Application added a project: KWin. · View Herald TranscriptOct 23 2019, 11:36 AM
Restricted Application added a subscriber: kwin. · View Herald Transcript
broulik requested review of this revision.Oct 23 2019, 11:36 AM
broulik edited the test plan for this revision. (Show Details)
davidedmundson accepted this revision.Oct 23 2019, 11:45 AM
davidedmundson added a subscriber: davidedmundson.

Not ideal, but better than before.

This revision is now accepted and ready to land.Oct 23 2019, 11:45 AM
Closed by commit R108:2ce1d9922111: [kcmkwin/kwindecoration] Elide "theme default border size" CheckBox (authored by broulik). · Explain WhyOct 23 2019, 11:48 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 68597

View Options

kcmkwin/kwindecoration/package/contents/ui/main.qml

Loading...