Differential D24883

[ComboBox] Don't indicate focus when popup is open
ClosedPublic
Actions

Authored by broulik on Oct 23 2019, 11:11 AM.

Details

Reviewers
mart
Group Reviewers
Plasma
Commits
R858:5dc1c74cad6f: [ComboBox] Don't indicate focus when popup is open
Summary

Technically the ComboBox has focus but the user is interacting with the popup inside.
This also mimics widget QComboBox where it doesn't glow bright blue while open.

Test Plan

Together with D24879 looks nice again

Diff Detail

Repository
R858 Qt Quick Controls 2: Desktop Style
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Oct 23 2019, 11:11 AM
Restricted Application added a project: Plasma. · View Herald TranscriptOct 23 2019, 11:11 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Oct 23 2019, 11:11 AM
mart accepted this revision.Nov 4 2019, 10:41 AM
This revision is now accepted and ready to land.Nov 4 2019, 10:41 AM
Closed by commit R858:5dc1c74cad6f: [ComboBox] Don't indicate focus when popup is open (authored by broulik). · Explain WhyNov 4 2019, 10:47 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Morg.kde.desktop/ComboBox.qml (2 lines)

Diff 69257

View Options

org.kde.desktop/ComboBox.qml

Loading...