Differential D24878

[x11] Check pending release when mapping
ClosedPublic
Actions

Authored by scao on Oct 23 2019, 6:38 AM.

Details

Reviewers
zzag
Group Reviewers
KWin
Commits
R108:1177ef372039: [x11] Check pending release when mapping
Summary

when unmap notify is followed by a map, the old Unmanaged will get released and never be managed again. by checking if there is a pending release operation, we can safely re-manage the window again.

BUG: 413350

Diff Detail

Repository
R108 KWin
Lint
Lint Skipped
Unit
Unit Tests Skipped
scao created this revision.Oct 23 2019, 6:38 AM
Restricted Application added a subscriber: kwin. · View Herald TranscriptOct 23 2019, 6:38 AM
scao requested review of this revision.Oct 23 2019, 6:38 AM
zzag added a subscriber: zzag.Oct 23 2019, 9:17 AM

That's a good discovery! Do you have a test client by any chance?

scao added a comment.Oct 23 2019, 9:34 AM

I have write a simple qt demo with only one override-redirected window, and clicking the button will produce the effect.

test_unmap.tar1 MBDownload

zzag accepted this revision.Oct 23 2019, 3:13 PM
zzag retitled this revision from check pending release when mapping to [x11] Check pending release when mapping.
zzag edited the summary of this revision. (Show Details)
This revision is now accepted and ready to land.Oct 23 2019, 3:13 PM
zzag added a comment.Oct 23 2019, 3:25 PM

Do you have commit access?

scao added a comment.Oct 24 2019, 12:41 AM

I believe I had, but a long time has passed since I last committed.

scao added a comment.Oct 24 2019, 1:15 AM

should I commit it now?

zzag added a comment.Oct 24 2019, 7:53 AM

Go for it.

scao closed this revision.Oct 24 2019, 10:20 AM

Revision Contents
Changeset List

PathPackages
Mevents.cpp (14 lines)
Munmanaged.h (2 lines)
Munmanaged.cpp (5 lines)

Diff 68585

View Options

events.cpp

Loading...
View Options

unmanaged.h

Loading...
View Options

unmanaged.cpp

Loading...