RFC: Move shortcuts out of ksmserver into kglobalaccel
Needs ReviewPublic

Authored by davidedmundson on Tue, Oct 22, 11:57 PM.


Group Reviewers

I want to move the shortcuts out of ksmserver. None of the actions now involve ksmserver directly and the
layering is now such that a wayland only session could run without ksmserver.

This patch uses .desktop file actions so kglobalaccel just calls the relevant hook directly rather than needing
a background service constantly running

WIP as:
I need migration,
I need to write the default shortcut in the correct syntax
We would need some way to hide the default _launch entry
Deal with a certain distro renaming qdbus

But I wanted some early feedback on whether this was a clever use of the existing framework, or a dirty hack.

Test Plan


Diff Detail

R120 Plasma Workspace
No Linters Available
No Unit Test Coverage
Build Status
Buildable 18058
Build 18076: arc lint + arc unit
Restricted Application added a project: Plasma. · View Herald TranscriptTue, Oct 22, 11:57 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
davidedmundson requested review of this revision.Tue, Oct 22, 11:57 PM

Deal with a certain distro renaming qdbus.

FWIW we have the same issue in other places too (https://bugs.kde.org/show_bug.cgi?id=413007) so perhaps a generic solution would work... or else maybe we should lobby said distro(s?) to make a compatibility symlink.

davidedmundson edited the summary of this revision. (Show Details)Wed, Oct 23, 12:08 AM
apol added a subscriber: apol.Wed, Oct 23, 1:57 AM

+1 conceptually.

We would need some way to hide the default _launch entry

I don't think that is a problem. I think we could wrap https://cgit.kde.org/kglobalaccel.git/tree/src/runtime/kserviceactioncomponent.cpp#n119 in an if and only register _launch if the [Desktop Entry] has an Exec line?