Adds option to ignore link-negotiation, also uses a combobox, similar to what
nm-connection-editor is using, to give a choice only with sane values for speed.
BUG: 413211
Details
Details
- Reviewers
davidedmundson - Group Reviewers
Plasma VDG - Commits
- R116:8b9eb87388cc: Wired setting: improve handling of link negotiation
I tried to configure all possible combinations, all of them were saved correctly and loaded afterwards.
Screenshot of updated wired setting:
Diff Detail
Diff Detail
- Repository
- R116 Plasma Network Management Applet
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
Looks like a complete fix to #413211. I've tested it on Arch Linux with different modes. For me Ignore, Auto and 10/100/1000 Mbps modes worked as intended as well as duplex setup for 10 and 100.
The only questionable thing is an ability to set Half duplex for 1Gbps and 10 Gbps. The first one is virtually never used IRL (and does not work for some (I guess many) NIC's, and the second one is absent in the standard and therefore unlikely to be found anywhere. NetworkManager saves these values and silently ignores it's unabilty to apply them to the hardware.
Comment Actions
I did basically what nm-connection-editor allows you to do. I also found somewhere that half-duplex is in the specification even for 1Gbps.
Comment Actions
Do you maybe want to review the code itself? It's not that complicated and nobody else seems to be interested.
| libs/editor/settings/wiredconnectionwidget.cpp | ||
|---|---|---|
| 79 | can loadConfig can be called multiple times? If so we need an explicit else {
setCurrentIndex(LinkNegotiation::Ignore);
} | |
| libs/editor/settings/wiredconnectionwidget.cpp | ||
|---|---|---|
| 79 | No, it cannot be called multiple times. | |