Differential D24855

Rename "Close Edit Mode" tooltip to "Finish Customizing Layout"
ClosedPublic
Actions

Authored by GB_2 on Oct 22 2019, 9:38 AM.

Details

Reviewers
ngraham
mart
Group Reviewers
Plasma
VDG
Commits
R119:a74c3657a071: Rename "Close Edit Mode" tooltip to "Finish Customizing Layout"
Summary

We don't call it the "edit mode" anywhere else in the UI. It now also matches the menu entry.

Test Plan

Hover over the desktop toolbox close button.

Diff Detail

Repository
R119 Plasma Desktop
Branch
arcpatch-D24855
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 18316
Build 18334: arc lint + arc unit
GB_2 created this revision.Oct 22 2019, 9:38 AM
Restricted Application added a project: Plasma. · View Herald TranscriptOct 22 2019, 9:38 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
GB_2 requested review of this revision.Oct 22 2019, 9:38 AM
ngraham added a subscriber: ngraham.Oct 22 2019, 1:57 PM

n alternative would be "Finish Customizing Layout" so it matches the menu entry.

+1

GB_2 updated this revision to Diff 68986.Oct 29 2019, 5:21 PM

"Close" -> "Finish Customizing Layout"

GB_2 retitled this revision from Rename "Close Edit Mode" tooltip to just "Close" to Rename "Close Edit Mode" tooltip to "Finish Customizing Layout".Oct 29 2019, 5:21 PM
GB_2 edited the summary of this revision. (Show Details)
ngraham accepted this revision.Oct 29 2019, 5:38 PM
This revision is now accepted and ready to land.Oct 29 2019, 5:38 PM
GB_2 added a reviewer: mart.Oct 29 2019, 6:13 PM
GB_2 added a subscriber: mart.
mart accepted this revision.Oct 30 2019, 2:54 PM
Closed by commit R119:a74c3657a071: Rename "Close Edit Mode" tooltip to "Finish Customizing Layout" (authored by GB_2). · Explain WhyOct 30 2019, 2:57 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 68986

View Options

toolboxes/desktoptoolbox/contents/ui/ToolBoxButton.qml

Loading...