fix kcm fonts "typo" on connect
ClosedPublic

Authored by bport on Oct 22 2019, 6:58 AM.

Details

Summary

connect was not done correctly

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
bport created this revision.Oct 22 2019, 6:58 AM
Restricted Application added a project: Plasma. · View Herald TranscriptOct 22 2019, 6:58 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
bport requested review of this revision.Oct 22 2019, 6:58 AM
broulik accepted this revision.Oct 22 2019, 6:59 AM
broulik added a subscriber: broulik.

Interesting, I thought Qt would/could static_assert that

This revision is now accepted and ready to land.Oct 22 2019, 6:59 AM
ervin accepted this revision.Oct 22 2019, 12:07 PM

Interesting, I thought Qt would/could static_assert that

Well, it turns out the signatures were compatible in fact (getters connected to a function which takes no parameter, signatures are fine). But since it is done by the C++ compiler, this one has no idea if the second parameter of the connect is indeed a signal (this is a completely alien concept to it). This is the one blind spot of the new style connects.

This revision was automatically updated to reflect the committed changes.