[Applet] Remove hamburger button and menu
AbandonedPublic

Authored by ngraham on Oct 21 2019, 9:41 PM.

Details

Reviewers
filipf
Group Reviewers
VDG
Plasma
Summary

This patch removes the hamburger button and menu, which user feedback indicates nobody clicks on. Its remaining
two functions ("raise maximum volume" and "play all audio through this device") are already exposed through clearer
and less buggy ways.

Test Plan
  • No more hamburger menu
  • You raise the maximum volume by clicking on the configure button in the applet to show the settings window and doing it there
  • You play all audio through the desired device by clicking on its Default Device button
    • When you do so, the slider's maximum value is immediately updated to the correct level

Probably needs lots of testing and I'm sure I did some stuff wrong 😛

Diff Detail

Repository
R115 Plasma Audio Volume Applet
Branch
single-way-to-raise-max-volume (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 18004
Build 18022: arc lint + arc unit
ngraham created this revision.Oct 21 2019, 9:41 PM
Restricted Application added a project: Plasma. · View Herald TranscriptOct 21 2019, 9:41 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.Oct 21 2019, 9:41 PM
filipf accepted this revision.Oct 21 2019, 9:57 PM
This revision is now accepted and ready to land.Oct 21 2019, 9:57 PM
ngraham planned changes to this revision.Oct 21 2019, 9:58 PM

Looks like it's a simple matter to get rid of the whole hamburger menu; I'll do it in this patch.

ngraham updated this revision to Diff 68494.Oct 21 2019, 11:31 PM

Remove the hamburger menu completely and fix the slider's max volume not adjusting dynamically

This revision is now accepted and ready to land.Oct 21 2019, 11:31 PM
ngraham retitled this revision from [Applet] Remove "Raise Maximum Volume" menu item from Hamburger menu to [Applet] Remove hamburger button and menu.Oct 21 2019, 11:37 PM
ngraham edited the summary of this revision. (Show Details)
ngraham edited the test plan for this revision. (Show Details)

user feedback indicates nobody clicks on.

You will get the feedback from people who use it after you have removed it and people can't use it anymore.

You raise the maximum volume by clicking on the configure button in the applet to show the settings window and doing it there

That's way slower. I use the functionality actually quite often for my bluetooth headset. That being said the functionality is somewhat broken for me because using hardware shortcuts after raising the maximum volume do not respect this. But after removing the switch from the applet do they then not work anymore for other people as well?

I believe you should put some more thoughts into how to consistently improve this plasmoid from usability point of view before doing singular drastic changes. Early feedback indicated for example that the current "Default Device" button might be too big for people's taste. Maybe @manueljlin can help with creating a harmonic overall design.

user feedback indicates nobody clicks on.

You will get the feedback from people who use it after you have removed it and people can't use it anymore.

It's the cycle of life. :) However the "Play all audio through this device" menu item is well and truly redundant now since the functionality is now exposed right on the main UI. I don't think anyone will miss it.

You raise the maximum volume by clicking on the configure button in the applet to show the settings window and doing it there

That's way slower. I use the functionality actually quite often for my bluetooth headset. That being said the functionality is somewhat broken for me because using hardware shortcuts after raising the maximum volume do not respect this.

Yeah, that bug is fixed here. The problem is that the "raise maximum volume" settings does not take into account the user-configured maximum volume setting and breaks when you use hardware media keys. It's quite messy and broken at the moment. We could fix that problem independently of this, but conceptually it's quite messy to have two subtly different ways to do the same thing.

But after removing the switch from the applet do they then not work anymore for other people as well?

After removing the menu item, the only way to raise the maximum volume is on a global basis using the settings window, after which the behavior is not buggy at all.

I believe you should put some more thoughts into how to consistently improve this plasmoid from usability point of view before doing singular drastic changes. Early feedback indicated for example that the current "Default Device" button might be too big for people's taste. Maybe @manueljlin can help with creating a harmonic overall design.

Definitely open to suggestions.

pkloc added a subscriber: pkloc.Oct 22 2019, 4:20 AM

There is use case for quick increase of maximum volume and I use it a lot, for quiet youtube videos.
I just checked, and "new" way is same amount of clicks away so I wouldn't oppose it too much. Still, personally old way feels more intuitive.

Now I'm starting to see benefits of LTS releases, I'm starting to feel like Plasma UI is changing too rapidly as of late.

broulik added a subscriber: broulik.EditedOct 22 2019, 7:11 AM

Big -1 to removing it on similar grounds as I also quite frequently use the raise maximum volume feature.

which user feedback indicates nobody clicks on.

So, we have KUserFeedback data already?

I believe you should put some more thoughts into how to consistently improve this plasmoid from usability point of view before doing singular drastic changes

This. I would have appreciated some overall vision for the Plasmoid's design rather than randomly removing and changing tiny bits all the time. It looks pretty ridiculous with those giant icons and massive defaults button right now which is by no means mitigated by removing that menu button.

(Also, if you really have to remove it, at least let me still access it by right clicking the device...)

ngraham abandoned this revision.Oct 22 2019, 1:39 PM

All right, sounds like this needs to go back to the drawing board. Sorry for raising everyone's blood pressure. :)

@manueljlin has some very nice mockups for an improved UI. Perhaps a saner approach is to first implement those, and then later, investigate ways to fix the issues described here. I do very much want to somehow fix the awkwardness and bugginess of having two methods to raise the maximum volume that conflict with one another.