[KDEPlatformSystemTrayIcon] Recreate deleted menu
ClosedPublic
Actions

Authored by kmaterka on Oct 21 2019, 7:31 PM.

Details

Reviewers

apol
davidedmundson
broulik
nicolasfella

Group Reviewers

Plasma
Frameworks

Commits

R135:bc1c85144adb: [KDEPlatformSystemTrayIcon] Recreate deleted menu

Summary

Recreate internal menu when needed.
It is possible that internal representation of system tray menu is
deleted. This can happen when QSystemTrayIcon is hidden.

BUG: 365105

Test Plan

Unit tests included

Diff Detail

Repository

R135 Integration for Qt applications in Plasma

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

kmaterka created this revision.Oct 21 2019, 7:31 PM

Restricted Application added a project: Plasma. · View Herald TranscriptOct 21 2019, 7:31 PM

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

kmaterka requested review of this revision.Oct 21 2019, 7:31 PM

Harbormaster completed remote builds in B17999: Diff 68482.Oct 21 2019, 7:31 PM

kmaterka added a reviewer: Plasma.Oct 21 2019, 7:32 PM

kmaterka mentioned this in D24755: [KStatusNotifierItem] Optionaly, do not take menu ownership.

kmaterka retitled this revision from [KDEPlatformSystemTrayIcon] Recreate menu when deleted to [KDEPlatformSystemTrayIcon] Recreate deleted menu.

kmaterka added reviewers: Frameworks, broulik, nicolasfella.Oct 22 2019, 6:34 AM

This is a proper solution to BUG 365105. Can someone review it? Is everything OK with this?

Any chance to get this reviewed? :)

apol accepted this revision.Nov 5 2019, 11:32 AM

This revision is now accepted and ready to land.Nov 5 2019, 11:32 AM

Closed by commit R135:bc1c85144adb: [KDEPlatformSystemTrayIcon] Recreate deleted menu (authored by kmaterka). · Explain WhyNov 5 2019, 11:43 AM

This revision was automatically updated to reflect the committed changes.

This causes menus (mostly submenus) to randomly show up when the SNI is updated, e.g. every time VLC changes a track I get its "speed (slower, normal, faster)" menu open:

(note the thick shadow, this is multiple menus stacked ontop of each other)

In D24843#560023, @broulik wrote:

This causes menus (mostly submenus) to randomly show up when the SNI is updated, e.g. every time VLC changes a track I get its "speed (slower, normal, faster)" menu open:

(note the thick shadow, this is multiple menus stacked ontop of each other)

I will fix that right away!

In D24843#560188, @kmaterka wrote:

In D24843#560023, @broulik wrote:

This causes menus (mostly submenus) to randomly show up when the SNI is updated, e.g. every time VLC changes a track I get its "speed (slower, normal, faster)" menu open:

I will fix that right away!

Fixed in D25223

Revision Contents
Changeset List

		Path
M		autotests/CMakeLists.txt (12 lines)
A	M	autotests/kdeplatformsystemtrayicon_unittest.cpp (106 lines)
M		src/platformtheme/kdeplatformsystemtrayicon.h (9 lines)
M		src/platformtheme/kdeplatformsystemtrayicon.cpp (61 lines)